diff options
| author | Mark Brown <broonie@kernel.org> | 2020-03-27 18:29:20 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-03-27 18:29:20 +0100 |
| commit | 1c521d7e62262793789845989edca57dea24eb7d (patch) | |
| tree | dd891362188494b9d665229696ffb72187998a00 /sound/soc/sof/intel/hda-ipc.c | |
| parent | Merge branch 'asoc-5.6' into asoc-linus (diff) | |
| parent | Merge series "ASoC: Intel: add SoundWire machine driver" from Pierre-Louis Bo... (diff) | |
| download | linux-1c521d7e62262793789845989edca57dea24eb7d.tar.xz linux-1c521d7e62262793789845989edca57dea24eb7d.zip | |
Merge branch 'asoc-5.7' into asoc-next
Diffstat (limited to 'sound/soc/sof/intel/hda-ipc.c')
| -rw-r--r-- | sound/soc/sof/intel/hda-ipc.c | 24 |
1 files changed, 6 insertions, 18 deletions
diff --git a/sound/soc/sof/intel/hda-ipc.c b/sound/soc/sof/intel/hda-ipc.c index 1837f66e361f..6062bb6011fb 100644 --- a/sound/soc/sof/intel/hda-ipc.c +++ b/sound/soc/sof/intel/hda-ipc.c @@ -106,7 +106,9 @@ void hda_dsp_ipc_get_reply(struct snd_sof_dev *sdev) ret = reply.error; } else { /* reply correct size ? */ - if (reply.hdr.size != msg->reply_size) { + if (reply.hdr.size != msg->reply_size && + /* getter payload is never known upfront */ + !(reply.hdr.cmd & SOF_IPC_GLB_PROBE)) { dev_err(sdev->dev, "error: reply expected %zu got %u bytes\n", msg->reply_size, reply.hdr.size); ret = -EINVAL; @@ -123,12 +125,6 @@ out: } -static bool hda_dsp_ipc_is_sof(uint32_t msg) -{ - return (msg & (HDA_DSP_IPC_PURGE_FW | 0xf << 9)) != msg || - (msg & HDA_DSP_IPC_PURGE_FW) != HDA_DSP_IPC_PURGE_FW; -} - /* IPC handler thread */ irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context) { @@ -174,17 +170,9 @@ irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context) */ spin_lock_irq(&sdev->ipc_lock); - /* handle immediate reply from DSP core - ignore ROM messages */ - if (hda_dsp_ipc_is_sof(msg)) { - hda_dsp_ipc_get_reply(sdev); - snd_sof_ipc_reply(sdev, msg); - } - - /* wake up sleeper if we are loading code */ - if (sdev->code_loading) { - sdev->code_loading = 0; - wake_up(&sdev->waitq); - } + /* handle immediate reply from DSP core */ + hda_dsp_ipc_get_reply(sdev); + snd_sof_ipc_reply(sdev, msg); /* set the done bit */ hda_dsp_ipc_dsp_done(sdev); |