diff options
author | John B. Wyatt IV <jwyatt@redhat.com> | 2024-10-01 01:21:54 +0200 |
---|---|---|
committer | Shuah Khan <skhan@linuxfoundation.org> | 2024-10-02 22:50:17 +0200 |
commit | 2314dca1b36629f352b0f919cdab16ca3fcaea42 (patch) | |
tree | 0d121df03a5f0a0377b17f6602911c1b665778d2 /tools/power | |
parent | pm: cpupower: gitignore: Add compile_commands.json (diff) | |
download | linux-2314dca1b36629f352b0f919cdab16ca3fcaea42.tar.xz linux-2314dca1b36629f352b0f919cdab16ca3fcaea42.zip |
pm: cpupower: bindings: Improve disable c_state block
This commit fixes a bad comment, removes an unneeded code block, and
catches a few more states that cpuidle_state_disable with the test
script. Part of the motivation for this commit was I kept forgetting to
use sudo.
Signed-off-by: "John B. Wyatt IV" <jwyatt@redhat.com>
Signed-off-by: "John B. Wyatt IV" <sageofredondo@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/power')
-rwxr-xr-x | tools/power/cpupower/bindings/python/test_raw_pylibcpupower.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tools/power/cpupower/bindings/python/test_raw_pylibcpupower.py b/tools/power/cpupower/bindings/python/test_raw_pylibcpupower.py index 3d6f62b9556a..bb2b26db8b10 100755 --- a/tools/power/cpupower/bindings/python/test_raw_pylibcpupower.py +++ b/tools/power/cpupower/bindings/python/test_raw_pylibcpupower.py @@ -15,21 +15,21 @@ else: print(f"cstate count error: return code: {cpu_cstates_count}") """ -Disable cstate (will fail if the above is 0, ex: a virtual machine) +Disable cstate (will fail if the above returns is under 1, ex: a virtual machine) """ cstate_disabled = p.cpuidle_state_disable(0, 0, 1) -if cpu_cstates_count == 0: - print(f"CPU 0 has {cpu_cstates_count} c-states") -else: - print(f"cstate count error: return code: {cpu_cstates_count}") match cstate_disabled: case 0: print(f"CPU state disabled") case -1: print(f"Idlestate not available") + case -2: + print(f"Disabling is not supported by the kernel") + case -3: + print(f"No write access to disable/enable C-states: try using sudo") case _: - print(f"Not documented") + print(f"Not documented: {cstate_disabled}") # Pointer example |