diff options
author | Daniel Thompson <daniel.thompson@linaro.org> | 2020-02-13 16:16:40 +0100 |
---|---|---|
committer | Daniel Thompson <daniel.thompson@linaro.org> | 2020-04-01 17:59:11 +0200 |
commit | ad99b5105c0823ff02126497f4366e6a8009453e (patch) | |
tree | 44e3f94cbac26b7e9208a2b4b1cabb30c77acabc /tools | |
parent | kdb: Eliminate strncpy() warnings by replacing with strscpy() (diff) | |
download | linux-ad99b5105c0823ff02126497f4366e6a8009453e.tar.xz linux-ad99b5105c0823ff02126497f4366e6a8009453e.zip |
kdb: Censor attempts to set PROMPT without ENABLE_MEM_READ
Currently the PROMPT variable could be abused to provoke the printf()
machinery to read outside the current stack frame. Normally this
doesn't matter becaues md is already a much better tool for reading
from memory.
However the md command can be disabled by not setting KDB_ENABLE_MEM_READ.
Let's also prevent PROMPT from being modified in these circumstances.
Whilst adding a comment to help future code reviewers we also remove
the #ifdef where PROMPT in consumed. There is no problem passing an
unused (0) to snprintf when !CONFIG_SMP.
argument
Reported-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions