diff options
author | Zhao Heming <heming.zhao@suse.com> | 2021-01-30 10:49:54 +0100 |
---|---|---|
committer | Jes Sorensen <jsorensen@fb.com> | 2021-03-03 15:29:17 +0100 |
commit | e6561c4defe853eaa6be27da0bb6bbd36e197b1f (patch) | |
tree | 6ce422f72180ea7bf1fad477bd3d963861c6295d | |
parent | Grow: be careful of corrupt dev_roles list (diff) | |
download | mdadm-e6561c4defe853eaa6be27da0bb6bbd36e197b1f.tar.xz mdadm-e6561c4defe853eaa6be27da0bb6bbd36e197b1f.zip |
super1: fix Floating point exception
write_bitmap1 didn't check return value of locate_bitmap1, which will
operate bitmap area under invalid bitmap info.
mdadm core dumped when doing below steps:
```
node1 # mdadm -C /dev/md0 -b none -e 1.2 -n 2 -l mirror /dev/sda /dev/sdb
node1 # mdadm -Ss
node1 # mdadm -A -U home-cluster --home-cluster=abc /dev/md0 /dev/sda /dev/sdb
Floating point exception (core dumped)
```
Signed-off-by: Zhao Heming <heming.zhao@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
-rw-r--r-- | super1.c | 5 |
1 files changed, 4 insertions, 1 deletions
@@ -2717,7 +2717,10 @@ static int write_bitmap1(struct supertype *st, int fd, enum bitmap_update update init_afd(&afd, fd); - locate_bitmap1(st, fd, 0); + if (locate_bitmap1(st, fd, 0) < 0) { + pr_err("Error: Invalid bitmap\n"); + return -EINVAL; + } if (posix_memalign(&buf, 4096, 4096)) return -ENOMEM; |