diff options
author | Tomasz Majchrzak <tomasz.majchrzak@intel.com> | 2017-09-07 13:01:16 +0200 |
---|---|---|
committer | Jes Sorensen <jsorensen@fb.com> | 2017-10-02 21:41:45 +0200 |
commit | e1b942b9afa9f3310ea19c57caea896af97b557e (patch) | |
tree | b1109840eeaacca99429a49e58d4072bb9fc8a3c /Grow.c | |
parent | Close mdfd before returning main function (diff) | |
download | mdadm-e1b942b9afa9f3310ea19c57caea896af97b557e.tar.xz mdadm-e1b942b9afa9f3310ea19c57caea896af97b557e.zip |
Grow: stop previous reshape process first
If array is stopped during reshape and assembled again straight away,
reshape process in a background might still be running. systemd doesn't
start a new service if one already exists. If there is a race, previous
process might terminate and new one is not created. Reshape doesn't
continue after assemble.
Tell systemd to restart the service rather than just start it. It will
assure previous service is stopped first. If it's not running, stopping
has no effect and only new process is started.
Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Diffstat (limited to 'Grow.c')
-rw-r--r-- | Grow.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -3003,9 +3003,9 @@ static int continue_via_systemd(char *devnm) snprintf(pathbuf, sizeof(pathbuf), "mdadm-grow-continue@%s.service", devnm); status = execl("/usr/bin/systemctl", "systemctl", - "start", + "restart", pathbuf, NULL); - status = execl("/bin/systemctl", "systemctl", "start", + status = execl("/bin/systemctl", "systemctl", "restart", pathbuf, NULL); exit(1); case -1: /* Just do it ourselves. */ |