diff options
author | Tomasz Majchrzak <tomasz.majchrzak@intel.com> | 2016-07-05 09:12:51 +0200 |
---|---|---|
committer | Jes Sorensen <Jes.Sorensen@redhat.com> | 2016-07-21 17:37:17 +0200 |
commit | 52209d6ee1183581e148791cf6ee4d60a0193b1d (patch) | |
tree | 518c81be1c4f86cf89c59caa72291bfc5d245412 /Monitor.c | |
parent | Remove: container should wait for an array to release a drive (diff) | |
download | mdadm-52209d6ee1183581e148791cf6ee4d60a0193b1d.tar.xz mdadm-52209d6ee1183581e148791cf6ee4d60a0193b1d.zip |
Monitor: release /proc/mdstat fd when no arrays present
If md kernel module is reloaded, /proc/mdstat cannot be accessed ("cat:
/proc/mdstat: No such file or directory"). The reason is mdadm monitor
still holds a file descriptor to previous /proc/mdstat instance. It
leads to really confusing outcome of the following operations - mdadm
seems to run without errors, however some udev rules don't get executed
and new array doesn't work.
Add a check if lseek was successful as it fails if md kernel module has
been unloaded - close a file descriptor then. The problem is mdadm
monitor doesn't always do it before next operation takes place. To
prevent it monitor always releases /proc/mdstat descriptor when there
are no arrays to be monitored, just in case driver unload happens in a
moment.
Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Diffstat (limited to 'Monitor.c')
-rw-r--r-- | Monitor.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -213,6 +213,8 @@ int Monitor(struct mddev_dev *devlist, if (mdstat) free_mdstat(mdstat); mdstat = mdstat_read(oneshot?0:1, 0); + if (!mdstat) + mdstat_close(); for (st=statelist; st; st=st->next) if (check_array(st, mdstat, c->test, &info, |