diff options
author | NeilBrown <neilb@suse.de> | 2013-07-30 05:45:22 +0200 |
---|---|---|
committer | NeilBrown <neilb@suse.de> | 2013-07-30 05:45:22 +0200 |
commit | 7ccc4cc4fc6889680bbe4ec673cab3f6aa49aad3 (patch) | |
tree | 509af03e40d95c181cf35d9c9ec673d8c913b191 /super0.c | |
parent | DDF: ddf_activate_spare: fix metadata update for SVDs (diff) | |
download | mdadm-7ccc4cc4fc6889680bbe4ec673cab3f6aa49aad3.tar.xz mdadm-7ccc4cc4fc6889680bbe4ec673cab3f6aa49aad3.zip |
Manage: remove call to validate_geometry.
This call to validate_geometry is really rather gratuitous.
It is purely about the fact that super0 cannot use more than 4TB.
So just make it an explicit test - less confusing that way.
With this, validate_geometry is only called from Create, which
makes it easier to reason about.
Also validate_geometry is now never passed NULL for the 'chunk'
parameter, so we can remove those annoying tests for NULL.
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'super0.c')
-rw-r--r-- | super0.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1274,7 +1274,7 @@ static int validate_geometry0(struct supertype *st, int level, "%d terabytes per device\n", tbmax); return 0; } - if (chunk && *chunk == UnSet) + if (*chunk == UnSet) *chunk = DEFAULT_CHUNK; if (!subdev) |