summaryrefslogtreecommitdiffstats
path: root/sftp-common.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2023-03-29upstream: fix memory leak; Coverity CID 291848djm@openbsd.org1-11/+10
with/ok dtucker@ OpenBSD-Commit-ID: 37f80cb5d075ead5a00ad1b74175684ab1156ff8
2023-03-28upstream: Plug more mem leaks in sftp by makingdtucker@openbsd.org2-8/+14
make_absolute_pwd_glob work in the same way as make_absolute: you pass it a dynamically allocated string and it either returns it, or frees it and allocates a new one. Patch from emaste at freebsd.org and https://reviews.freebsd.org/D37253 ok djm@ OpenBSD-Commit-ID: 85f7404e9d47fd28b222fbc412678f3361d2dffc
2023-03-28upstream: Remove compat code for OpenSSL < 1.1.*dtucker@openbsd.org1-9/+1
since -portable no longer supports them. OpenBSD-Commit-ID: ea2893783331947cd29a67612b4e56f818f185ff
2023-03-28upstream: Remove compat code for OpenSSL 1.0.*dtucker@openbsd.org1-9/+0
versions now that -portable has dropped support for those versions. OpenBSD-Regress-ID: 82a8eacd87aec28e4aa19f17246ddde9d5ce7fe7
2023-03-28Prevent conflicts between Solaris SHA2 and OpenSSL.Darren Tucker1-1/+23
We used to prevent conflicts between native SHA2 headers and OpenSSL's by setting OPENSSL_NO_SHA but that was removed prior to OpenSSL 1.1.0
2023-03-28Remove HEADER_SHA_H from previous...Darren Tucker1-1/+0
since it causes more problems than it solves.
2023-03-28Replace OPENSSL_NO_SHA with HEADER_SHA_H.Darren Tucker1-1/+1
Since this test doesn't use OpenSSL's SHA2 and may cause conflicts we don't want to include it, but OPENSSL_NO_SHA was removed beginning in OpenSSL's 1.1 series.
2023-03-28Configure with --target instead of deprecated form.Darren Tucker1-1/+1
2023-03-27Pass rpath when building 64bit Solaris.Darren Tucker1-1/+1
2023-03-27Explicitly disable OpenSSL on AIX test VM.Darren Tucker1-0/+1
2023-03-27upstream: Add RevokedHostKeys to percent expansion test.dtucker@openbsd.org1-2/+3
OpenBSD-Regress-ID: c077fd12a38005dd53d878c5b944154dec88d2ff
2023-03-27upstream: Add tilde and environment variable expansion todtucker@openbsd.org2-3/+20
RevokedHostKeys. bz#3552, ok djm@ OpenBSD-Commit-ID: ce5d8e0219b63cded594c17d4c2958c06918ec0d
2023-03-27upstream: fix test: getnameinfo returns a non-zero value on error, notdjm@openbsd.org1-2/+2
(neccessarily) -1. From GHPR#384 OpenBSD-Commit-ID: d35e2b71268f66f5543a7ea68751972b3ae22b25
2023-03-27upstream: scp: when copying local->remote, check that source filedjm@openbsd.org1-1/+7
exists before opening SFTP connection to the server. Based on GHPR#370 ok dtucker, markus OpenBSD-Commit-ID: b4dd68e15bfe22ce4fac9960a1066a2b721e54fb
2023-03-27Also look for gdb error message from OpenIndiana.Darren Tucker1-1/+1
2023-03-27Explicitly disable security key test on aix51 VM.Darren Tucker1-0/+1
We don't know how to build the shared objects required for the security key tests so skip them.
2023-03-26Split libcrypto and other config flags.Darren Tucker1-3/+6
This should allow the automatic OpenSSL version selection in the tests to work better.
2023-03-26Specify test target if we build without OpenSSL.Darren Tucker1-0/+3
When we decide we can't use the versions of OpenSSL available, also restrict the tests we run to avoid the ones that need OpenSSL.
2023-03-26Find suitable OpenSSL version.Darren Tucker1-3/+12
Check the installed OpenSSL versions for a suitable one, and if there isn't (and we don't have a specific version configured) then build without OpenSSL.
2023-03-24Github testing support for BoringSSLDamien Miller3-0/+18
2023-03-24BoringSSL doesn't support EC_POINT_point2bn()Damien Miller1-0/+2
so don't invoke it in unittest
2023-03-24another ERR_load_CRYPTO_strings() vestigeDamien Miller1-1/+1
2023-03-24don't use obsolete ERR_load_CRYPTO_strings()Damien Miller1-1/+1
OpenSSL (and elsewhere in OpenSSH) uses ERR_load_crypto_strings()
2023-03-24Allow building with BoringSSLDamien Miller2-0/+15
2023-03-24put back SSLeay_version compat in configure testDamien Miller1-1/+10
Needed to detect old versions and give good "your version is bad" messages at configure time; spotted by dtucker@
2023-03-24remove support for old libcryptoDamien Miller6-780/+40
OpenSSH now requires LibreSSL 3.1.0 or greater or OpenSSL 1.1.1 or greater with/ok dtucker@
2023-03-19Test latest OpenSSL 1.1, 3.0 and LibreSSL 3.7.Darren Tucker1-3/+3
2023-03-16Show 9.3 branch instead of 9.2.Darren Tucker1-3/+3
2023-03-15dependV_9_3_P1Damien Miller1-26/+25
2023-03-15crank versionDamien Miller3-3/+4
2023-03-15upstream: openssh-9.3djm@openbsd.org1-2/+2
OpenBSD-Commit-ID: 8011495f2449c1029bb316bd015eab2e00509848
2023-03-14upstream: Free KRL ptr in addition to its contents.dtucker@openbsd.org1-1/+2
From Coverity CID 291841, ok djm@ OpenBSD-Commit-ID: f146ba08b1b43af4e0d7ad8c4dae3748b4fa31b6
2023-03-14upstream: Check pointer for NULL before deref.dtucker@openbsd.org1-1/+3
None of the existing callers seem to do that, but it's worth checking. From Coverity CID 291834, ok djm@ OpenBSD-Commit-ID: a0a97113f192a7cb1a2c97b932f677f573cda7a4
2023-03-12upstream: Limit number of entries in SSH2_MSG_EXT_INFOdtucker@openbsd.org1-1/+6
request. This is already constrained by the maximum SSH packet size but this makes it explicit. Prompted by Coverity CID 291868, ok djm@ markus@ OpenBSD-Commit-ID: aea023819aa44a2dcb9dd0fbec10561896fc3a09
2023-03-12upstream: calloc can return NULL but xcalloc can't.dtucker@openbsd.org1-2/+2
From Coverity CID 291881, ok djm@ OpenBSD-Commit-ID: 50204b755f66b2ec7ac3cfe379d07d85ca161d2b
2023-03-12upstream: Explicitly ignore return from fcntldtucker@openbsd.org1-2/+2
(... FD_CLOEXEC) here too. Coverity CID 291853. OpenBSD-Commit-ID: 99d8b3da9d0be1d07ca8dd8e98800a890349e9b5
2023-03-10bounds checking for getrrsetbyname() replacement;Damien Miller1-8/+39
Spotted by Coverity in CID 405033; ok millert@
2023-03-10upstream: Plug mem leak on error path. Coverity CID 405026, ok djm@.dtucker@openbsd.org1-1/+2
OpenBSD-Commit-ID: 8212ca05d01966fb5e72205c592b2257708a2aac
2023-03-10Add prototypes for mkstemp replacements.Darren Tucker2-0/+2
Should prevent warnings due to our wrapper function.
2023-03-10upstream: Expliticly ignore return code from fcntl(.. FD_CLOEXEC) sincedtucker@openbsd.org1-4/+4
there's not much we can do anyway. From Coverity CID 291857, ok djm@ OpenBSD-Commit-ID: 051429dd07af8db3fec10d82cdc78d90bb051729
2023-03-10upstream: Like sshd_config, some ssh_config options are notdjm@openbsd.org1-3/+3
first-match-wins. sshd_config.5 was fixed in r1.348, this is the same for this file OpenBSD-Commit-ID: 7be55b9351cde449b136afcc52d07aa4113b215e
2023-03-10upstream: Remove no-op (int) > INT_MAX checksdtucker@openbsd.org1-5/+3
since they can never be true. From Coverity CID 405031, ok djm@ OpenBSD-Commit-ID: 9df3783b181e056595e2bb9edf7ed41d61cf8e84
2023-03-10Wrap mkstemp calls with umask set/restore.Darren Tucker2-0/+24
glibc versions 2.06 and earlier did not set a umask on files created by mkstemp created the world-writable. Wrap mkstemp to set and restore the umask. From Coverity (CIDs 291826 291886 291891), ok djm@
2023-03-10upstream: modify parentheses in conditionals to make it clearer what isjcs@openbsd.org3-8/+8
being assigned and what is being checked ok djm dtucker OpenBSD-Commit-ID: 19c10baa46ae559474409f75a5cb3d0eade7a9b8
2023-03-09upstream: Re-split the merge of the reorder-hostkeys test.dtucker@openbsd.org1-10/+13
In the kex_proposal_populate_entries change I merged the the check for reordering hostkeys with the actual reordering, but kex_assemble_names mutates options.hostkeyalgorithms which renders the check ineffective. Put the check back where it was. Spotted and tested by jsg@, ok djm@ OpenBSD-Commit-ID: a7469f25a738db5567395d1881e32479a7ffc9de
2023-03-09upstream: include destination constraints for smartcard keys too.djm@openbsd.org1-2/+2
Spotted by Luci Stanescu; ok deraadt@ markus@ OpenBSD-Commit-ID: add879fac6903a1cb1d1e42c4309e5359c3d870f
2023-03-09Limit the number of PAM environment variables.Darren Tucker1-0/+4
xcalloc has its own limits, but these are specific to PAM. From Coverity CID 405198, ok djm@
2023-03-09Limit the number of PAM environment variables.Darren Tucker1-5/+10
From Coverity CID 405194, tweaks and ok djm@
2023-03-08upstream: Plug mem leak. Coverity CID 405196, ok djm@dtucker@openbsd.org1-2/+4
OpenBSD-Commit-ID: 175f09349387c292f626da68f65f334faaa085f2
2023-03-08upstream: ssh-pkcs11: synchronize error messages with errorstb@openbsd.org1-4/+4
A handful of error messages contained incorrect function names or otherwise inaccurate descriptions. Fix them to match reality. input/ok djm OpenBSD-Commit-ID: 165a15db52f75b31e1804b043480c36af09f3411