From 0c7f8d2326d812b371f7afd63aff846973ec80a4 Mon Sep 17 00:00:00 2001 From: Darren Tucker Date: Tue, 8 Oct 2019 14:44:50 +1100 Subject: Make DEF_WEAK more likely to be correct. Completely nop-ing out DEF_WEAK leaves an empty statemment which some compilers don't like. Replace with a no-op function template. ok djm@ --- defines.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'defines.h') diff --git a/defines.h b/defines.h index e37e1647e..7855fbf90 100644 --- a/defines.h +++ b/defines.h @@ -839,9 +839,10 @@ struct winsize { /* * We want functions in openbsd-compat, if enabled, to override system ones. * We no-op out the weak symbol definition rather than remove it to reduce - * future sync problems. + * future sync problems. Some compilers (eg Unixware) do not allow an + * empty statement, so we use a bogus function declaration. */ -#define DEF_WEAK(x) +#define DEF_WEAK(x) void __ssh_compat_weak_##x(void) /* * Platforms that have arc4random_uniform() and not arc4random_stir() -- cgit v1.2.3