summaryrefslogtreecommitdiffstats
path: root/crypto/chacha/asm/chacha-loongarch64.pl
diff options
context:
space:
mode:
authorNeil Horman <nhorman@openssl.org>2025-01-10 20:37:28 +0100
committerNeil Horman <nhorman@openssl.org>2025-01-13 23:13:48 +0100
commit25f8e2c15b701514b7b2fe652634289b6fb8581f (patch)
tree19fd06233399df12918784945a86c6568d1c68c0 /crypto/chacha/asm/chacha-loongarch64.pl
parentFix intermittent test failure in 80-test_cmp_http.t (diff)
downloadopenssl-25f8e2c15b701514b7b2fe652634289b6fb8581f.tar.xz
openssl-25f8e2c15b701514b7b2fe652634289b6fb8581f.zip
Fix premature reuse of qp's in rcu locks
An intermittent failure was noted on our new ppc64le CI runner, in which what appeared to be a corrupted or invalid value getting returned from a shared pointer under rcu protection Investigation showed that the problem was with our small number of qp's in a lock, and slightly incorrect accounting of the number of qp's available we were prematurely recycling qp's, which led in turn to premature completion of synchronization states, resulting in readers reading memory that may have already been freed. Fix it by: a) Ensuring that we account for the fact that the first qp in an rcu lock is allocated at the time the lock is created and b) Ensuring that we have a minimum number of 3 qp's: 1 that is free for write side allocation 1 that is in use by the write side currently 1 "next" qp that the read side can update while the prior qp is being retired With this change, the rcu threadstest runs indefinately in my testing Fixes #26356 Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26384)
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions