summaryrefslogtreecommitdiffstats
path: root/units/cryptsetup.target (unfollow)
Commit message (Collapse)AuthorFilesLines
2019-07-18meson: make nologin path build time configurableMichael Biebl22-52/+61
Some distros install nologin as /usr/sbin/nologin, others as /sbin/nologin. Since we can't really on merged-usr everywhere (where the path wouldn't matter), make the path build time configurable via -Dnologin-path=. Closes #13028
2019-07-17resolved: switch cache option to a tri-state option (systemd#5552).Jorge Niedbalski11-8/+49
Change the resolved.conf Cache option to a tri-state "no, no-negative, yes" values. If a lookup returns SERVFAIL systemd-resolved will cache the result for 30s (See 201d995), however, there are several use cases on which this condition is not acceptable (See systemd#5552 comments) and the only workaround would be to disable cache entirely or flush it , which isn't optimal. This change adds the 'no-negative' option when set it avoids putting in cache negative answers but still works the same heuristics for positive answers. Signed-off-by: Jorge Niedbalski <jnr@metaklass.org>
2019-07-17network: update state file after dhcp6 eventsYu Watanabe1-0/+2
E.g. DNS servers may be received from DHCPv6 server. If the link is already in configured state, the DNS servers are not written in the state file.
2019-07-17Revert "test-network: extend sleep time"Yu Watanabe1-4/+4
This reverts commit 7d7bb5c8613b774bf77c531f46d31ee20d7a1b1e. Still the CIs are flaky and the commit just slow down them.
2019-07-17man: fix wrong section nameYu Watanabe1-1/+1
2019-07-17network: fix use after free()Yu Watanabe1-1/+1
The hashmap will be accessed by client_stop().
2019-07-17network: drop unnecessary line breaksYu Watanabe1-2/+0
2019-07-17network: drop fallback mechanism to assign DHCPv6 addresses with ↵Yu Watanabe3-14/+1
IFA_F_NOPREFIXROUTE The flag IFA_F_NOPREFIXROUTE was introduced in kernel-3.14. But even if the kernel does not support the flag, it should be just ignored. So, it is not necessary to do the fallback logic. Moreover, the current logic is not a fallback mechanism but just retrying. So, it should not work. Let's drop that.
2019-07-17test/TEST-16: don't copy systemd-notify or lib from $BUILD_DIRDan Streetman1-2/+0
On Ubuntu CI, these don't exist because it tests installed binaries, not just-built binaries.
2019-07-17Rewrite IN_SET()Zbigniew Jędrzejewski-Szmek1-1/+2
This restores proper speed with asan builds with gcc 9.1.1. Fixes #12997. $ rpm -q gcc gcc-9.1.1-2.fc31.x86_64 $ time ASAN_OPTIONS=strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1 UBSAN_OPTIONS=print_stacktrace=1:print_summary=1:halt_on_error=1 build-rawhide-sanitize/test-conf-parser (old) 86.99s user 20.22s system 361% cpu 29.635 total (new) 3.05s user 0.29s system 99% cpu 3.377 total Size is increased a bit: $ size build/systemd (old) 1683421 246100 1208 1930729 1d75e9 build/systemd (new) 1688237 246100 1208 1935545 1d88b9 build/systemd ... but that's <0.1%, so we don't really care.
2019-07-17Drop trailing slash from assert_cc() definitionZbigniew Jędrzejewski-Szmek6-8/+8
We use assert_cc(...); almost everywhere. Let's always require that. https://github.com/systemd/systemd/issues/12997#issuecomment-510103988
2019-07-17basic/macro: drop do {} while(0) from assert_not_reachedZbigniew Jędrzejewski-Szmek1-3/+1
log_assert_failed_unreachable is just a normal function call, no need to wrap it. https://github.com/systemd/systemd/issues/12997#issuecomment-510103988
2019-07-17firstboot: actually accept empty input to mean skipZbigniew Jędrzejewski-Szmek1-22/+17
We'd loop if the input was empty. We need to return to the caller.
2019-07-17firstboot: fix hang waiting for second Enter on inputZbigniew Jędrzejewski-Szmek1-1/+12
The comment explains the reason: we'd wait for the second \n and then ungetc() it. Then the buffered \n would cause a problem when the next prompt was issued, so in effect it wasn't possible to answer the second question.
2019-07-17firstboot: only list all options on demandZbigniew Jędrzejewski-Szmek1-27/+19
The user most likely knows the name of their locale/keymap/whatever, and paging through multiple pages of output has little benefit. The header that was printed before is now not printed anymore. But now it's obvious from the context what we are printing, so we don't need to print the header.
2019-07-17firstboot: use free_and_strdup, free_and_replaceZbigniew Jędrzejewski-Szmek1-11/+2
2019-07-17mount-util: bind_remount: avoid calling statvfsJakob Unterwurzacher1-4/+27
The commit "util: Do not clear parent mount flags when setting up namespaces" introduced a statvfs call read the flags of the original mount and have them applied to the bind mount. This has two problems: (1) The mount flags returned by statvfs(2) do not match the flags accepted by mount(2). For example, the value 4096 means ST_RELATIME when returned by statvfs(2), but means MS_BIND when passed to mount(2). (2) A call to statvfs blocks indefinitely when ran against a disconnected network drive ( https://github.com/systemd/systemd/issues/12667 ). We already use libmount to parse `/proc/self/mountinfo` but did not use the mount flag information from there. This patch changes that to use the mount flags parsed by libmount instead of calling statvfs. Only if getting the flags through libmount fails we call statvfs. Fixes https://github.com/systemd/systemd/issues/12667
2019-07-17sd-device: voidify and simplify calls to ordered_hashmap_iterate()Zbigniew Jędrzejewski-Szmek1-10/+2
Coverity CID#1402356 and CID#1402335.
2019-07-17sd-bus: voidify two calls to hashmap_iterate()Zbigniew Jędrzejewski-Szmek1-2/+2
Coverity CID#1402304 and CID#1402307.
2019-07-17test-networkd-conf: add missing assertZbigniew Jędrzejewski-Szmek1-1/+8
The test would not pass before, because EXTRACT_UNQUOTE|EXTRACT_RETAIN_ESCAPE didn't work (we'd get "KEY3=val with \\quotation\\" as the last string. Now we are only doing EXTRACT_UNQUOTE, so we get the expected "KEY3=val with \"quotation\"". Coverity CID#1402781.
2019-07-17shared/conf-parser,networkd: EXTRACT_UNQUOTE|EXTRACT_RETAIN_ESCAPE → ↵Zbigniew Jędrzejewski-Szmek4-2/+28
EXTRACT_UNQUOTE It's hard to even say what exactly this combination means. Escaping is necessary when quoting to have quotes within the string. So the escaping of quote characters is inherently tied to quoting. When unquoting, it seems natural to remove escaping which was done for the quoting purposes. But with both flags we would be expected to re-add this escaping after unqouting? Or maybe keep the escaping which is not necessary for quoting but otherwise present? This all seems too complicated, let's just forbid such usage and always fully unescape when unquoting.
2019-07-17nspawn: fix misplaced parenthesis and merge two error handling pathsZbigniew Jędrzejewski-Szmek1-7/+3
I don't think we need to provide the two separate error messages, let's shorten the code a bit by merging them. Coverity CID#1402320.
2019-07-17nspawn: fix memleak in argument parsingZbigniew Jędrzejewski-Szmek1-1/+1
Coverity CID#1402297.
2019-07-17coredumpctl: check return valueZbigniew Jędrzejewski-Szmek1-14/+16
retrieve() allocates memory, so it may fail. Coverity CID#1402338.
2019-07-17coredumpctl: use free_and_replace in one more placeZbigniew Jędrzejewski-Szmek1-3/+1
2019-07-17shared: voidify call to loop_write() and trim duplicate codeZbigniew Jędrzejewski-Szmek1-48/+34
Coverity CID#1402375.
2019-07-17shared: fix assert callZbigniew Jędrzejewski-Szmek1-1/+1
Fixup for 3572d3df8f8. Coverity CID#1403013.
2019-07-17core: ExecCondition= for servicesAnita Zhang21-23/+225
Closes #10596
2019-07-17nspawn: make use of SIGINT handling when copying filesLennart Poettering1-27/+43
Fixes: #13079
2019-07-17btrfs-util: expose SIGINT behaviour in snapshot copy fallback, tooLennart Poettering2-1/+2
2019-07-17copy: optionally check for SIGINT regularly, and abort operation safelyLennart Poettering2-1/+35
2019-07-17test/test-functions: fix install_dmeventd to correctly install bin/libsDan Streetman1-28/+1
2019-07-17Free up some resources on Azure PipelinesEvgeny Vereshchagin2-71/+0
Let's drop the tests we also run on CentOS CI to free up some resources for something more useful.
2019-07-17test/test-functions: instmods call to find should use -type fDan Streetman1-1/+1
without using -type f, the logs print an error such as: E: E: modprobe: FATAL: Module asymmetric_keys not found in directory /lib/modules/4.15.0-54-generic while this doesn't appear to cause problems, it can be extremely distracting when trying to debug real failures.
2019-07-17test: when stripping binaries, ignore case in suppressing "File format not ↵Dan Streetman1-1/+1
recognized" The grep -v matches all lowercase, but "file" is captialized; just ignore case so it's suppressed for either all lowercase or capital File.
2019-07-17test: ignore errors during test cleanup, so cleanup can finishDan Streetman2-17/+18
Also move TESTDIR and STATEFILE removal into test_cleanup
2019-07-17test: add create_empty_image_rootdir() to simplify testcase setupDan Streetman32-197/+76
Almost all tests were manually mounting/unmounting $TESTDIR/root from the loopback image; this moves all that into test-functions so the test setup functions are simplier. Also add test_setup_cleanup() function, to cleanup what is mounted by create_empty_image_rootdir()
2019-07-16test-network: drop warn_about_firewalld() as it is not necessary any moreYu Watanabe1-9/+0
2019-07-16test-network: stop firewalld in setUpModule()Yu Watanabe1-7/+14
2019-07-16test-network: add tests for link state file vs resolvectl or timedatectlYu Watanabe2-0/+107
2019-07-16resolve: fix memleakYu Watanabe1-0/+3
2019-07-16bash-completion: support ntp-servers and revert command for timedatectlYu Watanabe1-0/+9
2019-07-16timedatectl: add 'ntp-servers' and 'revert' commands to modify link NTP serversYu Watanabe2-0/+117
2019-07-16resolvectl: support networkd managed interfacesYu Watanabe2-150/+253
Closes #9808.
2019-07-16network: implement DBus methods to set DNS related propertiesYu Watanabe10-56/+865
2019-07-16resolve: expose dns_server_address_valid()Yu Watanabe5-18/+19
2019-07-16network: introduce GetLinkByName and GetLinkByIndex bus methodsYu Watanabe2-0/+79
2019-07-16network: implement ListLinks DBus methodYu Watanabe2-0/+46
2019-07-16network: move manager dbus prototypes to networkd-manager-bus.hYu Watanabe5-3/+13
2019-07-16pid1: make sure to restore correct default values for some rlimitsFranck Bui1-60/+106
Commit fb39af4ce42d7ef9af63009f271f404038703704 forgot to restore the default rlimit values (RLIMIT_NOFILE and RLIMIT_MEMLOCK) while PID1 is reloading. This patch extracts the code in charge of initializing the default values for those rlimits in order to create dedicated functions, which take care of their initialization. These functions are then called in parse_configuration() so we make sure that the default values for these rlimits get restored every time PID1 is reloading its configuration.