summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* fix template (#84563)HEADdevelBrian Coca32 hours4-5/+17
| | | | | | also fix gather_subset warning and add some comments/notes --------- Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* filters/flatten: fix input documentation (#84477)Max Gautier2 days1-2/+3
| | | Flatten input is a list, not a dictionary.
* host_group_vars - remove unnecessary os.path.join cache (#84549)Sloane Hertel3 days1-6/+1
|
* user: Fix homedir permissions when UMASK is unset in /etc/login.defsLee Garrett3 days3-10/+26
| | | | | | | | | | | | | | | When a user doesn't exist and user module is used to create the user and the homedir, adduser is called which parses HOME_MODE from /etc/login.defs, and when not set calculates the mode from UMASK from the same file. When a user already exists without homedir, and the user module is used to add a home dir, it incorrectly ignores HOME_MODE, resulting in a world-readable home dir when UMASK is not set. This is for example the case in Debian trixie and later, and likely Ubuntu 25.04 and later. Signed-off-by: Lee Garrett <lgarrett@rocketjump.eu> Co-authored-by: Brian Coca <bcoca@users.noreply.github.com> Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* Fix unit and integration tests (#84554)Matt Clay3 days2-3/+3
| | | This is a follow-up to https://github.com/ansible/ansible/pull/84473
* ansible-test - Use urllib intead of curl (#84551)Matt Clay4 days2-57/+44
| | | Also added automatic retries on HTTP request exceptions, since all currently implemented methods (GET/PUT/DELETE) are idempotent.
* fix incongruent ansible-vault cli options (#84494)Brian Coca4 days3-4/+20
| | | | | | | | prompt now only errors if stdin is specifically triggered and not due to lack of other args fixes #84489 --------- Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* ansible-vault integration test fix (fixes: #83837) (#84486)Lee Garrett4 days1-10/+13
| | | | | | Correct the test that expects an error when using ansible-vault to write against a non-writeable dir. Skip the test as root, as root can always write. Co-authored-by: Lee Garrett <lgarrett@rocketjump.eu>
* get_url: add support for BSD-style digest (#84485)Abhijeet Kasurde4 days4-21/+104
| | | | | | | | * Added support for BSD-style digest file to test checksum of downloaded file. Fixes: #84476 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Allows iptables chain creation with wait parameter (#84491)Kristopher Newsome4 days3-2/+14
| | | | | | | * Allows iptables chain creation with wait parameter Fixes #84490 * Add the changelog fragment for 84490
* User: Update prompt for SSH key passphrase prompt (#84521)Abhijeet Kasurde4 days2-3/+13
| | | | | | | | * update prompt for SSH key passphrase prompt * introduce timeout in SSH key passphrase interaction Fixes: #84484 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* fix[doc.py]: path will be undefined (#84464)Harilou4 days2-1/+4
| | | | | | | | | | | | | | | * fix[doc.py]: path will be undefined and a direct reference will throw an UnboundLocalError. If none of the files in files exists, path will be undefined and a direct reference will throw an UnboundLocalError. Repair function file parameter type annotation is inaccurate * Update changelogs/fragments/fix-cli-doc-path_undefined.yaml Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com> --------- Co-authored-by: Brian Coca <bcoca@users.noreply.github.com> Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* `with_dict` type error include value in error message (#84473)simonLeary424 days2-1/+3
| | | | | | | | | | | | | | | | | * with_dict better error message * include type in error message * changelog fragment * Update lib/ansible/plugins/lookup/dict.py Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com> * specific wording --------- Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* .github: simplify PR templates (#84536)Martin Krizek4 days5-58/+5
| | | | | | | It is rare that we need to provide information like "before and after the change". In majority of cases we just ignore "Additional information" when submitting PRs. We can just put the needed information into the summary if needed and remove the section from the template, simplifying it.
* Enforce FQCNs in seealso plugin/module entries. (#84325)Felix Fontein4 days2-2/+15
|
* Update ticketing stubs (#84535)Abhijeet Kasurde4 days10-28/+29
| | | Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Bump acme test container to 2.3.0 (#84547)Felix Fontein4 days2-1/+5
|
* host_group_vars - fix Python API traceback caused by undefined 'key' ↵xzeck5 days2-9/+11
| | | | | | | | | | | | | | | | | | | variable (#84488) Fixes: Traceback (most recent call last): File "/home/shertel/ansible/lib/ansible/plugins/vars/host_group_vars.py", line 139, in get_vars FOUND[key] = found_files = loader.find_vars_files(opath, entity_name) ^^^ UnboundLocalError: cannot access local variable 'key' where it is not associated with a value During handling of the above exception, another exception occurred: Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/shertel/ansible/lib/ansible/plugins/vars/host_group_vars.py", line 151, in get_vars raise AnsibleParserError(to_native(e)) ansible.errors.AnsibleParserError: cannot access local variable 'key' where it is not associated with a value
* ansible-test - Update utility containers (#84545)Matt Clay7 days4-3/+6
|
* fix warnings about reserved variable names to cover all sources (#84432)Brian Coca7 days12-12/+69
| | | | | | | Also remove redundant check from tqm Now covers module output (set_fact/include_vars) Includes play objects at any stage (tasks that error were not covered) Added tests, moved them to role structure
* Use ECR Public for container test (#84537)Matt Clay8 days1-1/+1
|
* constructed, let users know some limitations (#84510)Brian Coca8 days1-0/+4
| | | | | | | | | | | | | | | | | * constructed, let users know some limitations reasons https://forum.ansible.com/t/debugging-constructed-inventory-constructing-group-from-values-of-host-variables/39443 * fix indent * Update lib/ansible/plugins/doc_fragments/constructed.py Co-authored-by: Felix Fontein <felix@fontein.de> * updated as per fb --------- Co-authored-by: Felix Fontein <felix@fontein.de>
* FIX get_options function for CallbackBase (#84496)simonLeary4210 days3-2/+9
|
* 📝 Update the outdated WGs+community links in GH issues (#84523)🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)10 days1-2/+2
| | | | Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* 📝 Drop drop-down default note from issue forms (#84524)🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)10 days3-48/+3
| | | | Co-authored-by: flowerysong <junk+github@flowerysong.com>
* ansible-test - Fix FreeBSD instance CA certs (#84529)Matt Clay10 days2-0/+3
| | | | | Some versions and architectures come with `ca_root_nss` pre-installed. However, at least FreeBSD 13.4 on aarch64 does not. This change ensures the certificates will always be installed.
* ansible-test - Replace FreeBSD 14.1 with 14.2 (#84527)Matt Clay10 days5-15/+10
| | | | | * ansible-test - Replace FreeBSD 14.1 with 14.2 * Remove cron faketime testing from FreeBSD
* ansible-test - Replace RHEL 9.4 with 9.5 (#84526)Matt Clay10 days3-9/+10
|
* ansible-test - Replace Alpine 3.20 with 3.21 (#84525)Matt Clay10 days5-8/+10
|
* ansible-test - Replace Fedora 40 with 41 (#84281)Matt Clay10 days12-73/+60
| | | | | | | | | | | | | | | | | | | | | * ansible-test - Replace Fedora 40 with 41 Also update other distro containers to remove unnecessary packages: * apache2 * subversion * ruby * Fix subversion test on Ubuntu Also remove obsolete vars files from subversion test. * Skip dnf test on Fedora 41+ The dnf5 test is all that is needed. * Support dnf5 for the package test * Extend unix-chkpwd work-around for Fedora
* Add Keycloak service account auth capability to ansible-galaxy (#83145)Matt Martz10 days4-21/+39
|
* Fix uri integration test on Python 3.13 (#84518)Matt Clay11 days1-20/+85
|
* ansible-test - Update nios-test-container to 7.0.0 (#84517)Matt Clay11 days2-2/+2
|
* Fix result_pickle_error integration test (#84506)Matt Clay2025-01-032-3/+7
| | | | | The test has been updated to use a custom type which does not support pickling, instead of relying on Jinja's `Undefined` type. As of Jinja 3.1.5 that type now supports pickle, which breaks the original implementation of the test.
* test: Update regex for required and default in FieldAttributes (#84209)Abhijeet Kasurde2025-01-032-11/+16
| | | | | Fixes: #61460 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Added docstrings to V2 methods in the CallbackBase Class (4 & 5 of 27) (#83507)Rob Garcia2024-12-301-27/+51
| | | | | | | | | | | | | | | | | * Added docstrings to V2 methods in the CallbackBase Class (4 & 5 of 27) * Made corrections as requested by webknjaz. * Cleaned up whitespace issues. * Corrections to customization note for review by webknjaz. * Added rtype to return in docstrings. * Simplified docstrings. Co-authored-by: Brian Coca <bcoca@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
* Add documentation for non-numeric cron scheduling values (#84396)M Norrby2024-12-171-3/+9
| | | | - Document vixie cron compatible non-numeric values - State which parameters cannot be used together with special_time
* gather_facts, fix 'smart' handling with network os and 'setup' (#84425)Brian Coca2024-12-173-5/+39
| | | | | | | gather_facts, fix network_os and smart logic and defaults setup will be default for smart only if network_os is not set, now you get warnings and errors when missing a valid facts module for a network os Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* uri: move follow_redirects to module_utils (#84442)Abhijeet Kasurde2024-12-105-21/+41
| | | | | | * url lookup and uri module shares follow_redirects parameter, moving it module_utils code. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* adding option for form-multipart data to switch multipart encoding (#80566)David Lassig2024-12-106-3/+49
| | | | | | | * adding option for form-multipart data to switch multipart encoding from default base64 to 7or8bit encoding Co-authored-by: davlas <david.lassig@bwi.de> Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com> Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* Added None/empty notes to regex_search (#84437)Brian Coca2024-12-101-1/+4
|
* Make sure we are always using Lock from our multiprocessing context (#84453)Matt Martz2024-12-103-5/+8
| | | | | * Make sure we are always using Lock from our multiprocessing context * add clog frag
* Fix a debug message error (#84426)spyinx2024-12-102-1/+3
|
* copy, prevent internal options in task (#84422)Brian Coca2024-12-103-1/+22
| | | | | * copy, prevent internal options in task fixes #84367
* simplify copy module (#84313)Sloane Hertel2024-12-102-130/+47
| | | | | * simplify redundancy with AnsibleModule set_*_if_different methods * simplify copying a source directory to a dest directory without modifying behavior
* csvfile - let the config system do the typecasting (#82263)Herman van Rink2024-12-063-3/+19
| | | Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* lookup_template: added trim_blocks option (#84254)Abhijeet Kasurde2024-12-067-6/+67
| | | | | | | | | * Allow user to control the trimming of blocks while templating * Added tests * Updated documentation and example Fixes: #75962 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* test: Remove dead code (#84436)Abhijeet Kasurde2024-12-051-17/+4
| | | Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* unarchive: Clamp zip timestamps on 32-bit time_t (#84409)Stefano Rivera2024-12-053-1/+34
| | | | | | | | | | | | Clamp zip timestamps to representible values when unpacking zip files on platforms that use 32-bit time_t (e.g. Debian i386). This is a non-issue in practice (in 2024), but should allow the test suite to pass on Debian i386. We use a round value of 2038-01-01 00:00:00 for simplicity, and to avoid running into timezone offsets closer to the actual limit. MR #81520 introduced sanity-checking tests that used dates not representable with a 32-bit time_t.
* wait_for_connection - test connection=local does not emit warning (#84438)Sloane Hertel2024-12-051-0/+11
| | | Add test for PR 84421