diff options
| author | Loic Dachary <loic@dachary.org> | 2013-09-11 18:33:52 +0200 |
|---|---|---|
| committer | Loic Dachary <loic@dachary.org> | 2013-09-23 23:46:43 +0200 |
| commit | 8f0bb2f02fa7c6acd7ee624f13ce6f172e3d68b0 (patch) | |
| tree | 1740c13e6a6bd96968203abac5ced1813b3bb259 /ceph.spec.in | |
| parent | .gitignore gtags(1) generated files (diff) | |
| download | ceph-8f0bb2f02fa7c6acd7ee624f13ce6f172e3d68b0.tar.xz ceph-8f0bb2f02fa7c6acd7ee624f13ce6f172e3d68b0.zip | |
pybind: unit tests for ceph_argparse::parse_json_funcsigs
Run parse_json_funcsigs against the builtin commands found
in mon/MonCommands.h. Although it does not provide for a full
validation, it will detect some degenerate cases.
It is expected to raise if a space is missing at the end of an option
specification ( see https://github.com/ceph/ceph/pull/585 ) and this
case is tested. New tests of the same kind can be added whenever an
undetected error is found. Ideally a validation function is implemented
and it would be updated ( with an associated test ) when a new
pathological case is found.
The json string given to parse_json_funcsigs is obtained from
the support program get_command_descriptions.
The python-nose dependencies are added to the build requirements in
debian/control and ceph.spec.in because make check should always be run
at built time.
http://tracker.ceph.com/issues/6274 refs #6274
Reviewed-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
Signed-off-by: Loic Dachary <loic@dachary.org>
Diffstat (limited to 'ceph.spec.in')
| -rw-r--r-- | ceph.spec.in | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ceph.spec.in b/ceph.spec.in index 851ee7acfd5..a60d87ad814 100644 --- a/ceph.spec.in +++ b/ceph.spec.in @@ -37,6 +37,7 @@ BuildRequires: perl BuildRequires: gdbm BuildRequires: pkgconfig BuildRequires: python +BuildRequires: python-nose BuildRequires: libaio-devel BuildRequires: libcurl-devel BuildRequires: libxml2-devel |