diff options
author | Ilya Dryomov <idryomov@gmail.com> | 2025-01-16 19:13:44 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-01-16 19:13:44 +0100 |
commit | 34b378203288f3da2cdaff19e7fae2b05d58634f (patch) | |
tree | 15cf284f914e0add2c3d087baa43f68ae8b8dff5 /qa/tasks/cephadm.py | |
parent | Merge pull request #61393 from abhishek-kane/mapping_email (diff) | |
parent | qa/tasks: Include stderr on tasks badness check. (diff) | |
download | ceph-34b378203288f3da2cdaff19e7fae2b05d58634f.tar.xz ceph-34b378203288f3da2cdaff19e7fae2b05d58634f.zip |
Merge pull request #48539 from chrisphoffman/wip-57864
qa/tasks: Include stderr on tasks badness check
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'qa/tasks/cephadm.py')
-rw-r--r-- | qa/tasks/cephadm.py | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/qa/tasks/cephadm.py b/qa/tasks/cephadm.py index dab61c2c700..0cde6050718 100644 --- a/qa/tasks/cephadm.py +++ b/qa/tasks/cephadm.py @@ -475,12 +475,16 @@ def ceph_log(ctx, config): run.Raw('|'), 'head', '-n', '1', ]) r = ctx.ceph[cluster_name].bootstrap_remote.run( - stdout=StringIO(), + stdout=BytesIO(), args=args, + stderr=StringIO(), ) - stdout = r.stdout.getvalue() - if stdout != '': + stdout = r.stdout.getvalue().decode() + if stdout: return stdout + stderr = r.stderr.getvalue() + if stderr: + return stderr return None # NOTE: technically the first and third arg to first_in_ceph_log |