summaryrefslogtreecommitdiffstats
path: root/qa/tasks/s3tests_java.py
diff options
context:
space:
mode:
authorThomas Bechtold <tbechtold@suse.com>2019-12-09 16:17:23 +0100
committerThomas Bechtold <tbechtold@suse.com>2019-12-12 10:21:01 +0100
commit0127cd1e8817b05b1c3150540b021f9a24b47089 (patch)
tree4d70688e81f80ed40abe6bc126c1067eb1d46de8 /qa/tasks/s3tests_java.py
parentMerge pull request #32175 from rzarzynski/wip-crimson-errorator-do_with-frien... (diff)
downloadceph-0127cd1e8817b05b1c3150540b021f9a24b47089.tar.xz
ceph-0127cd1e8817b05b1c3150540b021f9a24b47089.zip
qa: Enable flake8 tox and fix failures
There were a couple of problems found by flake8 in the qa/ directory (most of them fixed now). Enabling flake8 during the usual check runs hopefully avoids adding new issues in the future. Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
Diffstat (limited to 'qa/tasks/s3tests_java.py')
-rw-r--r--qa/tasks/s3tests_java.py5
1 files changed, 1 insertions, 4 deletions
diff --git a/qa/tasks/s3tests_java.py b/qa/tasks/s3tests_java.py
index 47f9de1d2fc..e14bb5ea7dd 100644
--- a/qa/tasks/s3tests_java.py
+++ b/qa/tasks/s3tests_java.py
@@ -9,14 +9,11 @@ import os
import random
import string
import yaml
-import socket
import getpass
from teuthology import misc as teuthology
-from teuthology.exceptions import ConfigError
from teuthology.task import Task
from teuthology.orchestra import run
-from teuthology.orchestra.remote import Remote
log = logging.getLogger(__name__)
@@ -352,7 +349,7 @@ class S3tests_java(Task):
stdout=StringIO()
)
- if gr is not 'All':
+ if gr != 'All':
self.ctx.cluster.only(client).run(
args=args + ['--tests'] + [gr] + extra_args,
stdout=StringIO()