diff options
author | Patrick Donnelly <pdonnell@redhat.com> | 2019-02-06 23:48:57 +0100 |
---|---|---|
committer | Kefu Chai <tchaikov@gmail.com> | 2019-09-16 13:53:58 +0200 |
commit | 517bdca529db390e7ebc4e596570f80522060485 (patch) | |
tree | 3d7c2376b36f61ea8e85e97f6de515ccf6d6d4a1 /src/ceph-run | |
parent | common: add make_ref factory for RefCountedObject (diff) | |
download | ceph-517bdca529db390e7ebc4e596570f80522060485.tar.xz ceph-517bdca529db390e7ebc4e596570f80522060485.zip |
common/RefCountedObj: cleanup con/des
Also, don't allow children to set nref (to 0). This is the more significant
change as it required fixing various code to not do this:
<reftype> ptr = new RefCountedObjectFoo(..., 0);
as a way to create a starting reference with nref==1. This is a pretty
bad code smell so I've converted all the code doing this to use the new
factory method which produces the reference safely:
auto ptr = ceph::make_ref<RefCountedObjectFoo>(...);
libradosstriper was particularly egregious in its abuse of setting the starting
nref. :(
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Diffstat (limited to 'src/ceph-run')
0 files changed, 0 insertions, 0 deletions