diff options
| author | Kefu Chai <tchaikov@gmail.com> | 2024-05-24 11:51:55 +0200 |
|---|---|---|
| committer | Kefu Chai <tchaikov@gmail.com> | 2024-05-24 11:53:33 +0200 |
| commit | 02bd5e1b7f4e702af391308a14a6571660c16c32 (patch) | |
| tree | f0aeff33a0742f781c21ddf198aec4e1db120f25 /src/erasure-code | |
| parent | Merge pull request #57633 from mcv21/patch-1 (diff) | |
| download | ceph-02bd5e1b7f4e702af391308a14a6571660c16c32.tar.xz ceph-02bd5e1b7f4e702af391308a14a6571660c16c32.zip | |
cmake: : link shec_utils against legacy-option-headers
in c24a6ffe20, we tried to link all target dependent on legacy option
headers against legacy-option-headers, but we missed some of them.
in our CI, we spotted build failure like:
```
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/ErasureCode.cc:26:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/osd_types.h:41:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.h:41:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_proxy.h:6:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config.h:27:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_values.h:59:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/options/legacy_config_opts.h:1:10: fatal error: 'global_legacy_options.h' file not found
^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
so in this change, we link the shec_utils to `legacy-option-headers`
as well to fulfill the build dependency.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Diffstat (limited to 'src/erasure-code')
| -rw-r--r-- | src/erasure-code/shec/CMakeLists.txt | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/erasure-code/shec/CMakeLists.txt b/src/erasure-code/shec/CMakeLists.txt index 0e699203d7c..e7521542e31 100644 --- a/src/erasure-code/shec/CMakeLists.txt +++ b/src/erasure-code/shec/CMakeLists.txt @@ -10,6 +10,8 @@ set(shec_utils_srcs determinant.c) add_library(shec_utils OBJECT ${shec_utils_srcs}) +target_link_libraries(shec_utils + PRIVATE legacy-option-headers) set(ec_shec_objs $<TARGET_OBJECTS:gf-complete_objs> |