diff options
| author | Sage Weil <sage@inktank.com> | 2014-04-15 22:57:21 +0200 |
|---|---|---|
| committer | Sage Weil <sage@inktank.com> | 2014-04-15 22:57:21 +0200 |
| commit | 015df934afceec63d1d928c006d2be1639f0900c (patch) | |
| tree | a2f23c3824d9a6248e82b49943742a45108ddce4 /src/mon/MonCommands.h | |
| parent | Merge pull request #1661 from ceph/wip-objecter (diff) | |
| download | ceph-015df934afceec63d1d928c006d2be1639f0900c.tar.xz ceph-015df934afceec63d1d928c006d2be1639f0900c.zip | |
mon/OSDMonitor: require force argument to split a cache pool
There are several perils when splitting a cache pool:
- split invalidstes pg stats, which disables the agent
- a scrub must be manually triggered post-split to rebuild stats
- the pool may fill the OSDs during that period.
- or, the pool may end up beyond the 'full' mark and once scrub does
complete and the agent activate we may block IO for a long time while
we catch up with flush/evict
Make it a bit harder for users to shoot themselves in the foot.
Fixes: #8043
Signed-off-by: Sage Weil <sage@inktank.com>
Diffstat (limited to 'src/mon/MonCommands.h')
| -rw-r--r-- | src/mon/MonCommands.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/mon/MonCommands.h b/src/mon/MonCommands.h index 84af3d6a624..9fb83e25173 100644 --- a/src/mon/MonCommands.h +++ b/src/mon/MonCommands.h @@ -557,7 +557,8 @@ COMMAND("osd pool get " \ COMMAND("osd pool set " \ "name=pool,type=CephPoolname " \ "name=var,type=CephChoices,strings=size|min_size|crash_replay_interval|pg_num|pgp_num|crush_ruleset|hashpspool|hit_set_type|hit_set_period|hit_set_count|hit_set_fpp|debug_fake_ec_pool|target_max_bytes|target_max_objects|cache_target_dirty_ratio|cache_target_full_ratio|cache_min_flush_age|cache_min_evict_age " \ - "name=val,type=CephString", \ + "name=val,type=CephString " \ + "name=force,type=CephChoices,strings=--yes-i-really-mean-it,req=false", \ "set pool parameter <var> to <val>", "osd", "rw", "cli,rest") // 'val' is a CephString because it can include a unit. Perhaps // there should be a Python type for validation/conversion of strings |