*: switch trivial users of bufferlist::copy{_in} to iterators.

This commits switches the most straightforward occurrences of:
  * ceph::bufferlist::copy(off, len, dst) and
  * ceph::bufferlist::copy_in(off, len, src)
to use iterators. After extending `bufferlist::begin()` with
the `offset` parameter and eradication of the `last_p` hint,
these method look rudimentary. There is no huge benefit from

  bl.copy_in(off, len, dst)

instead of:

  bl.begin(off).copy_in(len, dst)

especially when `off` is `0`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/src/os/Transaction.h b/src/os/Transaction.h
index 3b8eb1bb2f5..769f6b5e735 100644
--- a/src/os/Transaction.h
+++ b/src/os/Transaction.h
@@ -543,7 +543,7 @@ public:
     ceph::buffer::list other_op_bl;
     {
       ceph::buffer::ptr other_op_bl_ptr(other.op_bl.length());
-      other.op_bl.copy(0, other.op_bl.length(), other_op_bl_ptr.c_str());
+      other.op_bl.begin().copy(other.op_bl.length(), other_op_bl_ptr.c_str());
       other_op_bl.append(std::move(other_op_bl_ptr));
     }