diff options
author | Lucian Petrut <lpetrut@cloudbasesolutions.com> | 2023-09-04 12:01:48 +0200 |
---|---|---|
committer | Lucian Petrut <lpetrut@cloudbasesolutions.com> | 2023-09-06 13:17:16 +0200 |
commit | 4ec8e9938b0de83c3a9fa94eb547ca450c3c864a (patch) | |
tree | cfb8c5fbbd185aed8313d5a749295981a99d3df6 /win32_deps_build.sh | |
parent | Merge pull request #53264 from anthonyeleven/anthonyeleven/improve-radosgw-ad... (diff) | |
download | ceph-4ec8e9938b0de83c3a9fa94eb547ca450c3c864a.tar.xz ceph-4ec8e9938b0de83c3a9fa94eb547ca450c3c864a.zip |
win32_build.sh: use ENABLE_SHARED=ON by default
The Windows build script uses static linking by default, the
reason being that some tests were failing to build otherwise,
mostly due to unspecified dependencies.
Now that the issue was addressed, we can enable dynamic linking
by default.
Worth mentioning that the Ceph MSI build script already uses
dynamic linking.
While at it, we'll drop some duplicate defaults from
"win32_deps_build.sh". For better clarity, we'll avoid exporting
some "win32_build.sh" variables, instead passing them explicitly
to "win32_deps_build.sh".
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Diffstat (limited to 'win32_deps_build.sh')
-rwxr-xr-x | win32_deps_build.sh | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/win32_deps_build.sh b/win32_deps_build.sh index adc34a01834..6eea81d1b8a 100755 --- a/win32_deps_build.sh +++ b/win32_deps_build.sh @@ -1,17 +1,10 @@ #!/usr/bin/env bash -set -e +set -eu SCRIPT_DIR="$(dirname "$BASH_SOURCE")" SCRIPT_DIR="$(realpath "$SCRIPT_DIR")" -USE_MINGW_LLVM=${USE_MINGW_LLVM:-} -ENABLE_SHARED=${ENABLE_SHARED:-OFF} - -num_vcpus=$(nproc) -NUM_WORKERS=${NUM_WORKERS:-$num_vcpus} - -DEPS_DIR="${DEPS_DIR:-$SCRIPT_DIR/build.deps}" depsSrcDir="$DEPS_DIR/src" depsToolsetDir="$DEPS_DIR/mingw" @@ -51,11 +44,6 @@ mingwLlvmUrl="https://github.com/mstorsjo/llvm-mingw/releases/download/20230320/ mingwLlvmSha256Sum="bc97745e702fb9e8f2a16f7d09dd5061ceeef16554dd12e542f619ce937e8d7a" mingwLlvmDir="${DEPS_DIR}/mingw-llvm" -# Allow for OS specific customizations through the OS flag (normally -# passed through from win32_build). -# Valid options are currently "ubuntu", "rhel", and "suse". -OS=${OS:-"ubuntu"} - function _make() { make -j $NUM_WORKERS $@ } |