summaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #61407 from clwluvw/replication-statusJ. Eric Ivancich14 hours1-9/+14
|\ | | | | | | | | rgw: update attrs with replication status to reflect in response Reviewed-by: Alex Wojno <awojno@bloomberg.net>
| * rgw: update attrs with replication status to reflect in responseSeena Fallah2 days1-9/+14
| | | | | | | | | | | | | | | | | | | | In handle_replication_status_header() when the COMPLETED status is being set to object's attr, it needs to be reflected to the current live attrs for the corresponding request so it can be reflected in the first try than the second. Fixes: https://tracker.ceph.com/issues/69549 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
* | Merge pull request #61406 from clwluvw/checkpoint-dstbucketJ. Eric Ivancich14 hours2-1/+2
|\ \ | | | | | | | | | | | | rgw: set dest bucket id in bucket sync checkpoint Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
| * | rgw: set dest bucket id in bucket sync checkpointSeena Fallah3 days2-1/+2
| |/ | | | | | | | | | | | | | | | | | | bucket_source_sync_checkpoint() requires bucket id to lookup for full-sync object and the dest pipe doesn't have it. by replcaning the bucket key in the pipe with the bucket info we will ensure the bucket id is set. Fixes: https://tracker.ceph.com/issues/69548 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
* | Merge pull request #61271 from clwluvw/datasync-usermode-errJ. Eric Ivancich14 hours1-2/+2
|\ \ | | | | | | | | | | | | rgw: set retcode on verify_bucket_permission in RGWObjFetchCR Reviewed-by: Casey Bodley <cbodley@redhat.com>
| * | rgw: skip on EACCES in RGWBucketSyncSingleEntryCRSeena Fallah9 days1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | As of offloading source bucket perm check to the source cluster by (a3f40b4) the http result of 403 would be translated to EACCES by rgw_http_error_to_errno() so we need to also consider EACCES to be skipped in RGWBucketSyncSingleEntryCR(). Signed-off-by: Seena Fallah <seenafallah@gmail.com>
| * | rgw: set retcode on verify_bucket_permission in RGWObjFetchCRSeena Fallah9 days1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | On destination bucket `verify_bucket_permission()` in `RGWObjFetchCR()` use `set_cr_error()` to return `-EPERM` so it can be reflected in `RGWBucketSyncSingleEntryCR()` for skipping on `-EPERM`. Fixes: https://tracker.ceph.com/issues/69450 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
* | | Merge pull request #61157 from aiivashchenko/fix_68195J. Eric Ivancich14 hours3-1/+3
|\ \ \ | | | | | | | | | | | | | | | | rgw: add missing last_modified field to swift api Reviewed-by: Casey Bodley <cbodley@redhat.com>
| * | | rgw: add missing last_modified field to swift apiAndrei Ivashchenko2024-12-233-1/+3
| | | | | | | | | | | | | | | | | | | | Fixes: https://tracker.ceph.com/issues/68195 Signed-off-by: Andrei Ivashchenko <aiivashchenko@users.noreply.github.com>
* | | | Merge pull request #59143 from Sean10/fix_rados_pybind_zero_paramYuri Weinstein16 hours2-1/+6
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pybind/rados: fix the incorrect order of offset,length in WriteOp.zero Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
| * | | | test/pybind/test_rados.py: add test for reversed arguments offset,length in ↵Wang Chao2024-11-051-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WriteOp.zero Before the fix, zero(0, 2) would have no effect, and read would get '12345' instead of the expected '\x00\x00345'. Signed-off-by: Wang Chao <sean10reborn@gmail.com>
| * | | | pybind/rados: fix the incorrect order of offset,length in WriteOp.zeroWang Chao2024-11-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The offset and length parameters in the rados pybind `WriteOp.zero()` method are being passed to the rados_write_op_zero() function in the incorrect order. Incorrect order cause OP_ZERO not work correctly when use pybind's rados. Signed-off-by: Wang Chao <sean10reborn@gmail.com>
* | | | | Merge pull request #61384 from sj14/sj/delete-policy-204J. Eric Ivancich17 hours1-1/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | rgw: S3 Delete Bucket Policy should return 204 on success Reviewed-by: Casey Bodley <cbodley@redhat.com>
| * | | | | rgw: S3 Delete Bucket Policy should return 204 on successSimon Jürgensmeyer3 days1-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, RGW returns a 200 on a successful DELETE on a bucket policy but the S3 API expects a 204: https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteBucketPolicy.html The sample response in the example above is a 204. This patch checks the op_ret in `RGWDeleteBucketPolicy::send_response()` and on a success we turn it to a 204 (or STATUS_NO_CONTENT). Fixes: https://tracker.ceph.com/issues/69539 Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
* | | | | | Merge pull request #61370 from yehudasa/wip-69536J. Eric Ivancich17 hours1-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | rgw: RGWRados::get_olh() needs to use the correct attr Reviewed-by: Casey Bodley <cbodley@redhat.com>
| * | | | | | rgw: RGWRados::get_olh() needs to use the correct attrYehuda Sadeh4 days1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://tracker.ceph.com/issues/69536 Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
* | | | | | | Merge pull request #61285 from cbodley/wip-69462J. Eric Ivancich18 hours1-0/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rgw: /admin/user api dumps account-related user info Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
| * | | | | | | rgw: /admin/user api dumps account-related user infoCasey Bodley9 days1-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the admin api uses a separate dump_user_info() function that wasn't updated with the account changes to RGWUserInfo::dump() Fixes: https://tracker.ceph.com/issues/69462 Signed-off-by: Casey Bodley <cbodley@redhat.com>
* | | | | | | | Merge pull request #61244 from awojno-bloomberg/fix-bucket-sync-statusJ. Eric Ivancich18 hours1-8/+6
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rgw: fix radosgw-admin use after free in bucket sync status Reviewed-By: Adam Emerson <aemerson@ibm.com> Reviewed-By: Oguzhan Ozmen <oozmen@bloomberg.net>
| * | | | | | | | rgw:fix radosgw-admin use after freeAlex Wojno9 days1-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Converted string_view members to string to avoid use after free. Bug introduced in commit: e84c7fc Signed-off-by: Alex Wojno <awojno@bloomberg.net>
* | | | | | | | | Merge pull request #60556 from ↵Adam Kupczyk23 hours2-31/+110
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | aclamk/wip-aclamk-bluefs-truncate-allocations-main os/bluestore: Make truncate() drop unused allocations - addendum
| * | | | | | | | | os/bluestore: Add unittest for BlueFS::truncate()Adam Kupczyk2024-10-301-0/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add unittest for some truncate scenarios. Fixes: https://tracker.ceph.com/issues/68385 (addendum) Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
| * | | | | | | | | os/bluestore: Make truncate() drop unused allocationsAdam Kupczyk2024-10-291-31/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Review fixes. Removed overcatious assert. Improved if .. else style. Skipped processing extent truncation when seek() goes to end. Fixes: https://tracker.ceph.com/issues/68385 (addendum) Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
* | | | | | | | | | Merge pull request #60363 from aclamk/wip-aclamk-fix-bluefs-bdev-expandAdam Kupczyk23 hours1-2/+27
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | os/bluestore: Create additional bdev labels when expanding block device.
| * | | | | | | | | | os/bluestore: Fix CBT bluefs-bdev-expandAdam Kupczyk2024-10-161-2/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a problem when expansion of 'block' device crossed location of bdev label copy. The extra label that did not exist before and now exist was not initialized. Also changed logic of 'bluestore_bdev_label_require_all'. Previously label locations 0..bdev->size() were taken in to account. Now labels in range bdev_label.size..bdev->size() are excluded. Fixes: https://tracker.ceph.com/issues/68577 Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
* | | | | | | | | | | Merge pull request #61412 from gbregman/mainGil Bregman32 hours3-0/+8
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | mgr/cephadm/nvmeof: Add SPDK iobuf options field to NVMeOF configuration
| * | | | | | | | | | | mgr/cephadm/nvmeof: Add SPDK iobuf options field to NVMeOF configurationGil Bregman39 hours3-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://tracker.ceph.com/issues/69554 Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
* | | | | | | | | | | | Merge pull request #60265 from MaxKellermann/timeout_round_upYuri Weinstein33 hours3-6/+52
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | msg/async: round timeouts up (fix busy loops) Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
| * | | | | | | | | | | msg/async/Timeout: always round upMax Kellermann2024-10-221-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, we always round down, which has a bad side effect: when a timer comes closer, we have lots of early wakeups, and eventually we'll run into a busy loop (timeout=0) when the timeout is less than one millisecond; the process will remain this busy loop for one millisecond, wasting lots of CPU time. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
| * | | | | | | | | | | msg/async/Event{Poll,Epoll}: move timeout calculation to Timeout.hMax Kellermann2024-10-223-6/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is duplicate code, and it's buggy, but I want to fix only one copy. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
* | | | | | | | | | | | Merge pull request #61349 from VallariAg/wip-vallari-nvmeof-ceph-versionVallari Agrawal46 hours1-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | mon: do not show nvmeof in 'ceph versions' output
| * | | | | | | | | | | | mon: do not show nvmeof in 'ceph versions' outputVallari Agrawal2 days1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NVMeoF gateway version is independent of ceph version so 'ceph version' shows wrong nvmeof version in output (i.e. instead of gateway version, it shows Ceph version). Hence, remove nvmeof in 'ceph versions' output. To check for gateway version, use 'gw info' command. Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
* | | | | | | | | | | | | Merge pull request #60889 from anoopcs9/fix-invalid-access-mdsMilind Changire47 hours1-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | mds: Fix invalid access of mdr->dn[0].back()
| * | | | | | | | | | | | mds: Fix invalid access of mdr->dn[0].back()Anoop C S2024-11-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/ceph/ceph/pull/31534 for a similar fix. Fixes: https://tracker.ceph.com/issues/69059 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
* | | | | | | | | | | | | Merge pull request #61211 from yuvalif/wip-yuval-logging-tenantYuval Lifshitz3 days12-162/+648
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rgw/logging: add more validations to conf, cross tenant support and cleanup Reviewed-By: Adam Emerson <aemerson@ibm.com>, Ali Masarwe <ali.masarwa@ibm.com>
| * | | | | | | | | | | | | rgw/logging: clean pending objectsYuval Lifshitz5 days12-129/+561
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * when source bucket is deleted * when logging is disabled * when logging conf changes * when target bucket is deleted also add "bucket logging info" admin command returning logging conf for source bucket, and list of source buckets for log bucket Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
| * | | | | | | | | | | | | rgw/logging: retry attribuite set in case of raceYuval Lifshitz5 days1-45/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
| * | | | | | | | | | | | | rgw/logging: log bucket must not have encryptionYuval Lifshitz5 days1-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
| * | | | | | | | | | | | | rgw/logging: source and log bucket must be differentYuval Lifshitz5 days1-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
| * | | | | | | | | | | | | rgw/logging: support source and destination buckets on different tenantsYuval Lifshitz5 days2-41/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
* | | | | | | | | | | | | | Merge pull request #61373 from anthonyeleven/fix-file-descriptionsZac Dover3 days1-4/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AsyncMessenger.cc : improve error messages Reviewed-by: Zac Dover <zac.dover@proton.me>
| * | | | | | | | | | | | | | AsyncMessenger.cc : improve error messagesAnthony D'Atri3 days1-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
* | | | | | | | | | | | | | | Merge pull request #61289 from ronen-fr/wip-rf-catcher-fixRonen Friedman3 days1-7/+16
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | common: fix md_config_cacher_t Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
| * | | | | | | | | | | | | | common: config_cacher: use set::contains() instead of count()Ronen Friedman4 days1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | moved out of the main commit to facilitate backporting it to pre-C++20. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | | | | | | | common: fix md_config_cacher_tRonen Friedman4 days1-7/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In its get_tracked_conf_keys() member function, the cacher (in the existing code) initializes a static function-block variable ('keys'), and uses it for registering the observer. But the cacher is instantiated on the type of the configuration value. Thus, multiple cacher objects for which the configuration values are of the same type - share the static 'keys'. Only one of the observers is registered. Note that the code could have been simplified somewhat, if the signature of the get_tracked_conf_keys() function was changed to return 'const char* const *'. Fixes: https://tracker.ceph.com/issues/69236 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
* | | | | | | | | | | | | | | Merge pull request #61072 from pecastro/doc_and_test_fixesAnthony D'Atri3 days3-7/+7
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doc and test fixes
| * | | | | | | | | | | | | | | tools/cephfs: fix flake8 f-string formatting for py3.12Paulo E. Castro2024-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
| * | | | | | | | | | | | | | | doc: Fix typo.Paulo E. Castro2024-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
| * | | | | | | | | | | | | | | test/pybind: Test method has been renamed in unittest 3.2Paulo E. Castro2024-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
| * | | | | | | | | | | | | | | test/pybind: Clean whitespace.Paulo E. Castro2024-12-121-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>