| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
rgw: update attrs with replication status to reflect in response
Reviewed-by: Alex Wojno <awojno@bloomberg.net>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In handle_replication_status_header() when the COMPLETED status is
being set to object's attr, it needs to be reflected to the current
live attrs for the corresponding request so it can be reflected in
the first try than the second.
Fixes: https://tracker.ceph.com/issues/69549
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
|\ \
| | |
| | |
| | |
| | | |
rgw: set dest bucket id in bucket sync checkpoint
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
bucket_source_sync_checkpoint() requires bucket id to lookup for
full-sync object and the dest pipe doesn't have it. by replcaning
the bucket key in the pipe with the bucket info we will ensure the
bucket id is set.
Fixes: https://tracker.ceph.com/issues/69548
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
|\ \
| | |
| | |
| | |
| | | |
rgw: set retcode on verify_bucket_permission in RGWObjFetchCR
Reviewed-by: Casey Bodley <cbodley@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As of offloading source bucket perm check to the source cluster by (a3f40b4)
the http result of 403 would be translated to EACCES by rgw_http_error_to_errno()
so we need to also consider EACCES to be skipped in RGWBucketSyncSingleEntryCR().
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On destination bucket `verify_bucket_permission()` in `RGWObjFetchCR()`
use `set_cr_error()` to return `-EPERM` so it can be reflected in
`RGWBucketSyncSingleEntryCR()` for skipping on `-EPERM`.
Fixes: https://tracker.ceph.com/issues/69450
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
rgw: add missing last_modified field to swift api
Reviewed-by: Casey Bodley <cbodley@redhat.com>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes: https://tracker.ceph.com/issues/68195
Signed-off-by: Andrei Ivashchenko <aiivashchenko@users.noreply.github.com>
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
pybind/rados: fix the incorrect order of offset,length in WriteOp.zero
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
WriteOp.zero
Before the fix, zero(0, 2) would have no effect, and read would get '12345' instead of the expected '\x00\x00345'.
Signed-off-by: Wang Chao <sean10reborn@gmail.com>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The offset and length parameters in the rados pybind `WriteOp.zero()` method are being passed to the rados_write_op_zero() function in the incorrect order.
Incorrect order cause OP_ZERO not work correctly when use pybind's rados.
Signed-off-by: Wang Chao <sean10reborn@gmail.com>
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
rgw: S3 Delete Bucket Policy should return 204 on success
Reviewed-by: Casey Bodley <cbodley@redhat.com>
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently, RGW returns a 200 on a successful DELETE on a bucket policy but
the S3 API expects a 204:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteBucketPolicy.html
The sample response in the example above is a 204.
This patch checks the op_ret in `RGWDeleteBucketPolicy::send_response()`
and on a success we turn it to a 204 (or STATUS_NO_CONTENT).
Fixes: https://tracker.ceph.com/issues/69539
Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
rgw: RGWRados::get_olh() needs to use the correct attr
Reviewed-by: Casey Bodley <cbodley@redhat.com>
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes: https://tracker.ceph.com/issues/69536
Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
rgw: /admin/user api dumps account-related user info
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
the admin api uses a separate dump_user_info() function that wasn't
updated with the account changes to RGWUserInfo::dump()
Fixes: https://tracker.ceph.com/issues/69462
Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
rgw: fix radosgw-admin use after free in bucket sync status
Reviewed-By: Adam Emerson <aemerson@ibm.com>
Reviewed-By: Oguzhan Ozmen <oozmen@bloomberg.net>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Converted string_view members to string to avoid use after free.
Bug introduced in commit: e84c7fc
Signed-off-by: Alex Wojno <awojno@bloomberg.net>
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
aclamk/wip-aclamk-bluefs-truncate-allocations-main
os/bluestore: Make truncate() drop unused allocations - addendum
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Add unittest for some truncate scenarios.
Fixes: https://tracker.ceph.com/issues/68385 (addendum)
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Review fixes. Removed overcatious assert.
Improved if .. else style.
Skipped processing extent truncation when seek() goes to end.
Fixes: https://tracker.ceph.com/issues/68385 (addendum)
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | | |
os/bluestore: Create additional bdev labels when expanding block device.
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
There was a problem when expansion of 'block' device crossed location
of bdev label copy. The extra label that did not exist before and now
exist was not initialized.
Also changed logic of 'bluestore_bdev_label_require_all'.
Previously label locations 0..bdev->size() were taken in to account.
Now labels in range bdev_label.size..bdev->size() are excluded.
Fixes: https://tracker.ceph.com/issues/68577
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
|
|\ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | |
| | | | | | | | | | | | |
mgr/cephadm/nvmeof: Add SPDK iobuf options field to NVMeOF configuration
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Fixes https://tracker.ceph.com/issues/69554
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
|
|\ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / /
|/| | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
msg/async: round timeouts up (fix busy loops)
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Currently, we always round down, which has a bad side effect: when a
timer comes closer, we have lots of early wakeups, and eventually
we'll run into a busy loop (timeout=0) when the timeout is less than
one millisecond; the process will remain this busy loop for one
millisecond, wasting lots of CPU time.
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
This is duplicate code, and it's buggy, but I want to fix only one
copy.
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
|
|\ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | |
| | | | | | | | | | | | | |
mon: do not show nvmeof in 'ceph versions' output
|
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | | |
NVMeoF gateway version is independent of ceph version
so 'ceph version' shows wrong nvmeof version in output
(i.e. instead of gateway version, it shows Ceph version).
Hence, remove nvmeof in 'ceph versions' output.
To check for gateway version, use 'gw info' command.
Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
|
|\ \ \ \ \ \ \ \ \ \ \ \ \
| |_|_|_|_|_|_|_|_|_|_|_|/
|/| | | | | | | | | | | | |
mds: Fix invalid access of mdr->dn[0].back()
|
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | | |
See https://github.com/ceph/ceph/pull/31534 for a similar fix.
Fixes: https://tracker.ceph.com/issues/69059
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
|
|\ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
rgw/logging: add more validations to conf, cross tenant support and cleanup
Reviewed-By: Adam Emerson <aemerson@ibm.com>, Ali Masarwe <ali.masarwa@ibm.com>
|
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
* when source bucket is deleted
* when logging is disabled
* when logging conf changes
* when target bucket is deleted
also add "bucket logging info" admin command
returning logging conf for source bucket, and list
of source buckets for log bucket
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
AsyncMessenger.cc : improve error messages
Reviewed-by: Zac Dover <zac.dover@proton.me>
|
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |_|_|_|_|_|_|_|_|_|_|/ / / /
|/| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
common: fix md_config_cacher_t
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
|
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
moved out of the main commit to
facilitate backporting it to pre-C++20.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
|
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
In its get_tracked_conf_keys() member function, the
cacher (in the existing code) initializes a static
function-block variable ('keys'), and uses it for
registering the observer.
But the cacher is instantiated on the type of
the configuration value. Thus, multiple cacher
objects for which the configuration values are
of the same type - share the static 'keys'. Only
one of the observers is registered.
Note that the code could have been simplified
somewhat, if the signature of the
get_tracked_conf_keys() function
was changed to return 'const char* const *'.
Fixes: https://tracker.ceph.com/issues/69236
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
Doc and test fixes
|
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
|
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
|
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
|
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
|