diff options
author | Martin Hertz <mvhertz@gmail.com> | 2024-08-16 14:21:03 +0200 |
---|---|---|
committer | Calum Lind <calumlind+deluge@gmail.com> | 2024-09-08 11:04:42 +0200 |
commit | c88f750108ede64cdd1e4ea143981b9212b13360 (patch) | |
tree | 46d836b5440318d32d60310720756a481f4d1d1c /.pre-commit-config.yaml | |
parent | [CI] Fix accidental revert of Twisted pin for Windows (diff) | |
download | deluge-c88f750108ede64cdd1e4ea143981b9212b13360.tar.xz deluge-c88f750108ede64cdd1e4ea143981b9212b13360.zip |
[Console] Block interactive-mode on Windows even with windows-curses
Testing with window-curses results in hangs on initial loading with background error:
File "C:\Users\Docker\Deluge\.venv\lib\site-packages\twisted\internet\selectreactor.py", line 39, in win32select
r, w, e = select.select(r, w, w, timeout)
builtins.OSError: [WinError 10038] An operation was attempted on something that is not a socket
This is due to passing a Console class to addReader but this fails since
select on Windows cannot handle non-socket file object unlike Unix which accepts
sockets and file objects.
There is likely a further issue where windows-curses has not implemented
resizeterm so would need to use resize_term instead.
Refs: https://docs.python.org/3/library/select.html#select.select
Refs: https://stackoverflow.com/questions/11731175/python-twisted-addreader-works-in-linux-but-not-windows
Refs: https://github.com/zephyrproject-rtos/windows-curses/issues/40
Refs: https://docs.python.org/3/library/curses.html#curses.resize_term
Closes: https://github.com/deluge-torrent/deluge/pull/457
Co-authored-by: Calum Lind <calumlind+deluge@gmail.com>
Diffstat (limited to '.pre-commit-config.yaml')
0 files changed, 0 insertions, 0 deletions