summaryrefslogtreecommitdiffstats
path: root/Dockerfile
diff options
context:
space:
mode:
authorEarl Warren <contact@earl-warren.org>2024-08-21 07:27:38 +0200
committerEarl Warren <contact@earl-warren.org>2024-08-21 07:27:38 +0200
commit6c8d9823ac6414d7e89af0be56d4b9fe41a0d682 (patch)
treebbd853633c689b47648dfe4ce5c791009d28fee3 /Dockerfile
parentMerge pull request 'Update dependency chart.js to v4.4.4 (forgejo)' (#5037) f... (diff)
downloadforgejo-6c8d9823ac6414d7e89af0be56d4b9fe41a0d682.tar.xz
forgejo-6c8d9823ac6414d7e89af0be56d4b9fe41a0d682.zip
fix: release: Forgejo version is not set
LDFLAGS="-buildid=" must be set in the environment so the Makefile adds to it. Setting it via the make arguments overrides it and removes the -X "main.*Version" arguments which are used to set the Forgejo version of the binary. Regression introduced in [CHORE] Support reproducible builds' (#4970)
Diffstat (limited to 'Dockerfile')
-rw-r--r--Dockerfile2
1 files changed, 1 insertions, 1 deletions
diff --git a/Dockerfile b/Dockerfile
index 4453d9abf3..1355b7061a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -36,7 +36,7 @@ WORKDIR ${GOPATH}/src/code.gitea.io/gitea
RUN make clean
RUN make frontend
RUN go build contrib/environment-to-ini/environment-to-ini.go && xx-verify environment-to-ini
-RUN make RELEASE_VERSION=$RELEASE_VERSION GOFLAGS="-trimpath" LDFLAGS="-buildid=" go-check generate-backend static-executable && xx-verify gitea
+RUN LDFLAGS="-buildid=" make RELEASE_VERSION=$RELEASE_VERSION GOFLAGS="-trimpath" go-check generate-backend static-executable && xx-verify gitea
# Copy local files
COPY docker/root /tmp/local