diff options
author | Earl Warren <contact@earl-warren.org> | 2025-01-17 08:42:20 +0100 |
---|---|---|
committer | Earl Warren <earl-warren@noreply.codeberg.org> | 2025-01-17 08:42:20 +0100 |
commit | 376a2e19eab62640257b40db8163a0cab92c7038 (patch) | |
tree | e2d344f5802a43140e2be244bcbc7e59af16a67b /release-notes/4427.md | |
parent | [PORT] Remove SHA1 for support for ssh rsa signing (#31857) (#5303) (diff) | |
download | forgejo-376a2e19eab62640257b40db8163a0cab92c7038.tar.xz forgejo-376a2e19eab62640257b40db8163a0cab92c7038.zip |
fix: reduce noise for the v303 migration (#6591)
Using SELECT `%s` FROM `%s` WHERE 0 = 1 to assert the existence of a column is simple but noisy: it shows errors in the migrations that are confusing for Forgejo admins because they are not actual errors.
Use introspection instead, which is more complicated but leads to the same result.
Add a test that ensures it works as expected, for all database types. Although the migration is run for all database types, it does not account for various scenarios and is never tested in the case a column does not exist.
Refs: https://codeberg.org/forgejo/forgejo/issues/6583
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6591
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
Diffstat (limited to 'release-notes/4427.md')
0 files changed, 0 insertions, 0 deletions