diff options
| author | Gusted <postmaster@gusted.xyz> | 2024-07-14 07:38:45 +0200 |
|---|---|---|
| committer | Gusted <postmaster@gusted.xyz> | 2024-08-18 17:04:00 +0200 |
| commit | 15c64122a667cf6a4a143fcf9f60c253133f3dcc (patch) | |
| tree | 7113bd33ba468042b38e4a018fdbd98f4006974d /release-notes | |
| parent | Merge pull request 'Update docker.io/bitnami/minio Docker tag to v2024.8.17 (... (diff) | |
| download | forgejo-15c64122a667cf6a4a143fcf9f60c253133f3dcc.tar.xz forgejo-15c64122a667cf6a4a143fcf9f60c253133f3dcc.zip | |
[BUG] Don't fire notification for comment of pending review
- When a comment was updated or deleted and was part of an
pending/ongoing review, it would have triggered a notification, such as
a webhook.
- This patch checks if the comment is part of a pending review and then
does not fire a notification and, in the case of updating a comment,
does not save the content history because this is not necessary if it is
still a "draft" comment given it is a pending comment (there is no need
to see my embarrassing typos).
- Adds integration tests.
- Resolves https://codeberg.org/forgejo/forgejo/issues/4368
Diffstat (limited to 'release-notes')
| -rw-r--r-- | release-notes/4487.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/release-notes/4487.md b/release-notes/4487.md new file mode 100644 index 0000000000..3c2767a427 --- /dev/null +++ b/release-notes/4487.md @@ -0,0 +1 @@ +Do not fire webhook notifications for updates and deletions of comments that are part of an ongoing review (a review that is still in draft). Also, content history will not be saved for such comments, to avoid exposing fixing embarrassing typos you've have made while the review was still pending. |