diff options
| author | delvh <dev.lh@web.de> | 2023-12-25 21:25:29 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-25 21:25:29 +0100 |
| commit | 778ad795fd4a19dc15723b59a846a250034c7c3a (patch) | |
| tree | 8d64a21734517a9826655955d77cb0bcc187f784 /services/secrets | |
| parent | Refactor CORS handler (#28587) (diff) | |
| download | forgejo-778ad795fd4a19dc15723b59a846a250034c7c3a.tar.xz forgejo-778ad795fd4a19dc15723b59a846a250034c7c3a.zip | |
Refactor deletion (#28610)
Introduce the new generic deletion methods
- `func DeleteByID[T any](ctx context.Context, id int64) (int64, error)`
- `func DeleteByIDs[T any](ctx context.Context, ids ...int64) error`
- `func Delete[T any](ctx context.Context, opts FindOptions) (int64,
error)`
So, we no longer need any specific deletion method and can just use
the generic ones instead.
Replacement of #28450
Closes #28450
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'services/secrets')
| -rw-r--r-- | services/secrets/secrets.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/secrets/secrets.go b/services/secrets/secrets.go index 97e15ba6c7..031c474dd7 100644 --- a/services/secrets/secrets.go +++ b/services/secrets/secrets.go @@ -76,7 +76,7 @@ func DeleteSecretByName(ctx context.Context, ownerID, repoID int64, name string) } func deleteSecret(ctx context.Context, s *secret_model.Secret) error { - if _, err := db.DeleteByID(ctx, s.ID, s); err != nil { + if _, err := db.DeleteByID[secret_model.Secret](ctx, s.ID); err != nil { return err } return nil |