diff options
| author | zeripath <art27@cantab.net> | 2022-01-07 02:18:52 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-07 02:18:52 +0100 |
| commit | 21ed4fd8da4c8992518dcfb01aa7306f7406f735 (patch) | |
| tree | eb0bdaed8d06849116818f058b6120633d329d69 /templates/repo/blame.tmpl | |
| parent | [skip ci] Updated translations via Crowdin (diff) | |
| download | forgejo-21ed4fd8da4c8992518dcfb01aa7306f7406f735.tar.xz forgejo-21ed4fd8da4c8992518dcfb01aa7306f7406f735.zip | |
Add warning for BIDI characters in page renders and in diffs (#17562)
Fix #17514
Given the comments I've adjusted this somewhat. The numbers of characters detected are increased and include things like the use of U+300 to make à instead of à and non-breaking spaces.
There is a button which can be used to escape the content to show it.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Gwyneth Morgan <gwymor@tilde.club>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Diffstat (limited to 'templates/repo/blame.tmpl')
| -rw-r--r-- | templates/repo/blame.tmpl | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/templates/repo/blame.tmpl b/templates/repo/blame.tmpl index cdd31c0eba..3dc3522275 100644 --- a/templates/repo/blame.tmpl +++ b/templates/repo/blame.tmpl @@ -16,11 +16,13 @@ {{end}} <a class="ui tiny button" href="{{.RepoLink}}/src/{{.BranchNameSubURL}}/{{.TreePath | PathEscapeSegments}}">{{.i18n.Tr "repo.normal_view"}}</a> <a class="ui tiny button" href="{{.RepoLink}}/commits/{{.BranchNameSubURL}}/{{.TreePath | PathEscapeSegments}}">{{.i18n.Tr "repo.file_history"}}</a> + <a class="ui tiny button unescape-button">{{.i18n.Tr "repo.unescape_control_characters"}}</a> + <a class="ui tiny button escape-button" style="display: none;">{{.i18n.Tr "repo.escape_control_characters"}}</a> </div> </div> </h4> <div class="ui attached table unstackable segment"> - <div class="file-view code-view"> + <div class="file-view code-view unicode-escaped"> <table> <tbody> {{range $row := .BlameRows}} @@ -52,6 +54,9 @@ <td class="lines-num"> <span id="L{{$row.RowNumber}}" data-line-number="{{$row.RowNumber}}"></span> </td> + {{if $.EscapeStatus.Escaped}} + <td class="lines-escape">{{if $row.EscapeStatus.Escaped}}<a href="" class="toggle-escape-button" title="{{$.i18n.Tr "repo.line_unicode"}}"></a>{{end}}</td> + {{end}} <td rel="L{{$row.RowNumber}}" rel="L{{$row.RowNumber}}" class="lines-code blame-code chroma"> <code class="code-inner pl-3">{{$row.Code}}</code> </td> |