diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-02-19 05:06:14 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-19 05:06:14 +0100 |
| commit | d32af84a1002ceb235c86e4ac569c866ab7816d4 (patch) | |
| tree | 3832638122aac31fdc2215f85873629fd8ef2fd2 /templates/repo/migrate/migrating.tmpl | |
| parent | Scoped labels (#22585) (diff) | |
| download | forgejo-d32af84a1002ceb235c86e4ac569c866ab7816d4.tar.xz forgejo-d32af84a1002ceb235c86e4ac569c866ab7816d4.zip | |
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
Close #22847
This PR:
* introduce Gitea's own `showElem` and related functions
* remove jQuery show/hide
* remove .hide class
* remove inline style=display:none
From now on:
do not use:
* "[hidden]" attribute: it's too weak, can not be applied to an element
with "display: flex"
* ".hidden" class: it has been polluted by Fomantic UI in many cases
* inline style="display: none": it's difficult to tweak
* jQuery's show/hide/toggle: it can not show/hide elements with
"display: xxx !important"
only use:
* this ".gt-hidden" class
* showElem/hideElem/toggleElem functions in "utils/dom.js"
cc: @silverwind , this is the all-in-one PR
Diffstat (limited to 'templates/repo/migrate/migrating.tmpl')
| -rw-r--r-- | templates/repo/migrate/migrating.tmpl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/templates/repo/migrate/migrating.tmpl b/templates/repo/migrate/migrating.tmpl index e6d329a1ab..a3552610c4 100644 --- a/templates/repo/migrate/migrating.tmpl +++ b/templates/repo/migrate/migrating.tmpl @@ -12,7 +12,7 @@ <img src="{{AssetUrlPrefix}}/img/loading.png"/> </div> </div> - <div id="repo_migrating_failed_image" class="sixteen wide center aligned centered column" style="display: none;"> + <div id="repo_migrating_failed_image" class="sixteen wide center aligned centered column gt-hidden"> <div> <img src="{{AssetUrlPrefix}}/img/failed.png"/> </div> @@ -24,7 +24,7 @@ <p>{{.locale.Tr "repo.migrate.migrating" .CloneAddr | Safe}}</p> <p id="repo_migrating_progress_message"></p> </div> - <div id="repo_migrating_failed" hidden> + <div id="repo_migrating_failed" class="gt-hidden"> {{if .CloneAddr}} <p>{{.locale.Tr "repo.migrate.migrating_failed" .CloneAddr | Safe}}</p> {{else}} |