diff options
| author | silverwind <me@silverwind.io> | 2024-04-18 11:01:06 +0200 |
|---|---|---|
| committer | Gergely Nagy <forgejo@gergo.csillger.hu> | 2024-04-22 08:09:00 +0200 |
| commit | a01387f5b176f4305e7728a265dc926dd21111e7 (patch) | |
| tree | c669942cb4c0cc9b64eca9bbeaa22e1234006612 /templates | |
| parent | Merge pull request '[UI] Fix and refactor for milestone headers' (#3340) from... (diff) | |
| download | forgejo-a01387f5b176f4305e7728a265dc926dd21111e7.tar.xz forgejo-a01387f5b176f4305e7728a265dc926dd21111e7.zip | |
Add form field id generation, remove duplicated ids (#30546)
Fixes: https://github.com/go-gitea/gitea/issues/30384
On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.
Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.
I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)
Conflicts:
- templates/repo/settings/options.tmpl
Conflict resolved by manually removing all `id` and `for`
attributes from elements that had `repo_name` as their id.
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/repo/settings/options.tmpl | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl index 1d1fdb36ef..aeb61d9eb3 100644 --- a/templates/repo/settings/options.tmpl +++ b/templates/repo/settings/options.tmpl @@ -9,8 +9,8 @@ {{.CsrfTokenHtml}} <input type="hidden" name="action" value="update"> <div class="required field {{if .Err_RepoName}}error{{end}}"> - <label for="repo_name">{{ctx.Locale.Tr "repo.repo_name"}}</label> - <input id="repo_name" name="repo_name" value="{{.Repository.Name}}" data-repo-name="{{.Repository.Name}}" autofocus required> + <label>{{ctx.Locale.Tr "repo.repo_name"}}</label> + <input name="repo_name" value="{{.Repository.Name}}" data-repo-name="{{.Repository.Name}}" autofocus required> </div> <div class="inline field"> <label>{{ctx.Locale.Tr "repo.repo_size"}}</label> @@ -539,8 +539,8 @@ </label> </div> <div class="required field"> - <label for="repo_name">{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> - <input id="repo_name" name="repo_name" required maxlength="100"> + <label>{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> + <input name="repo_name" required maxlength="100"> </div> <div class="text right actions"> @@ -570,8 +570,8 @@ </label> </div> <div class="required field"> - <label for="repo_name">{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> - <input id="repo_name" name="repo_name" required> + <label>{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> + <input name="repo_name" required> </div> <div class="text right actions"> @@ -602,8 +602,8 @@ </label> </div> <div class="required field"> - <label for="repo_name">{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> - <input id="repo_name" name="repo_name" required> + <label>{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> + <input name="repo_name" required> </div> <div class="required field"> <label for="new_owner_name">{{ctx.Locale.Tr "repo.settings.transfer_owner"}}</label> @@ -672,8 +672,8 @@ </label> </div> <div class="required field"> - <label for="repo_name">{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> - <input id="repo_name" name="repo_name" required> + <label>{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> + <input name="repo_name" required> </div> <div class="text right actions"> @@ -705,8 +705,8 @@ </label> </div> <div class="required field"> - <label for="repo_name">{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> - <input id="repo_name" name="repo_name" required> + <label>{{ctx.Locale.Tr "repo.settings.confirmation_string"}}</label> + <input name="repo_name" required> </div> <div class="text right actions"> |