summaryrefslogtreecommitdiffstats
path: root/web_src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* chore: fix typos, decap a few i18n strings (#6666)0ko6 days1-1/+1
| | | | | | | | | | | | A few typos, some from spell checker, some from grepping `the the`, `the a `, ` a the`. Some in comments and some in changelogs. Decapped a few remaining annoying strings, and one new from https://codeberg.org/forgejo/forgejo/pulls/6351 which was introduced by copy-pasting on a slightly out-of-date branch, causing Weblate to issue "reused translation" alerts again. Ref #6439. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6666 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>
* Alt Linux Apt-Rpm repository support for Forgejo packages. (#6351)Alex6198297 days1-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Aleksandr Gamzin alexgamz1119@gmail.com Adds support for the Apt-Rpm registry of the Alt Lunux distribution. Alt Linux uses RPM packages to store and distribute software to its users. But the logic of the Alt Linux package registry is different from the Red Hat package registry. I have added support for the Alt Linux package registry. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [x] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [ ] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Co-authored-by: Aleksandr Gamzin <gamzin@altlinux.org> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6351 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Alex619829 <alex619829@noreply.codeberg.org> Co-committed-by: Alex619829 <alex619829@noreply.codeberg.org>
* fix(tests): prevent frontend test dependency on system locale (#6649)0ko8 days1-5/+3
| | | | | | | | | | | This test depended on system locale. It always failed with `LANG=fr_FR make test-frontend` and always passed with `LANG=C make test-frontend`. - prevent this dependency by explicitly passing 'en-US' - avoid process.env.TZ boilerplate with vi.stubEnv Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6649 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Beowulf <beowulf@beocode.eu>
* Lock file maintenance (forgejo) (#6630)Renovate Bot9 days1-42/+42
| | | | | | | Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6630 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
* fix(ui): prevent overflow of branch selector in commit graph (#6617)Otto9 days1-6/+13
|\ | | | | | | | | | | | | Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6617 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: 0ko <0ko@noreply.codeberg.org> Reviewed-by: Otto <otto@codeberg.org>
| * fix(ui): prevent overflow of branch selector in commit graphBeowulf10 days1-6/+13
| |
* | Fix mention and emoji expansion & Improve leaving list completion (#6597)0ko9 days1-4/+20
|\ \ | | | | | | | | | | | | Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6597 Reviewed-by: 0ko <0ko@noreply.codeberg.org>
| * | Leave list/quote expanison with double enterBeowulf11 days1-4/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When editing a list or similar syntax elements, pressing enter starts a new line with the line introducer (e.g. `- ` for a plain list). But currently it's uncomfortable when someone wants to leave the list. Pressing enter again simply adds more and more lines with the prefix. With this change the list is terminated if enter is pressed on a line which contains the introducer but nothing else. This behavior is known from other markdown editors like the on used by GitLab or GitHub. Additionally I changed the regex for detecting a prefix. - Why: With the change you can add a single whitespace at the end if you want to keep an "empty" line. So if you want to write: ``` - First - - Third ``` You just need to add a whitespace in the second line to prevent that the prefix will be removed. - Changes in detail: - ordered bullet list prefix detection: nothing changed - todo list and unordered list prefix detection: have been split up: - todo list: Changed that only 1 to 4 whitespaces can be between the list char (`-`,`*`,`+`) and the checkbox (`[ ]`,`[x]`) - Why? If more then 4 spaces are between the list char and the checkbox, this is no longer detected as a prefix for a todo item based on the markdown standard. Due to the amount of spaces it is instead parsed as code. - unordered list: The prefix now needs to have exactly one space after the list char (`-`,`*`,`+`). More spaces will not be taken into account for detecting the prefix. - quote prefix detection: nothing changed The current e2e-tests where simplified and duplicated tests where removed. Test cases for the new functionality where added.
| * | Prevent prefix continuation if currently a text expander popup is openBeowulf11 days1-0/+2
| |/ | | | | | | | | This fixes that mentions and emoji autocompletion was broken in e.g. a list, because the list handling take presidency over the text expansion.
* / Remove DiffFileList componentBeowulf10 days4-94/+2
|/ | | | | | | | | The benefit / functionality provided by DiffFileList is already (better) integrated in the header of the files. If you want an overview, you can collapse all files via the same overflow menu (where the stats were available). To reduce the maintenance effort, the DiffFileList component is therefore removed.
* fix(ui): reset content of text field for comments when cancelling (#6595)Beowulf12 days1-0/+1
| | | | | | | | | | | | Currently, the content of the text field is not reset when you cancel editing. This change resets the content of the text field when editing is canceled. If this is not done and you click on cancel and then on edit again, you can no longer return to the initial content without completely reloading the page. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6595 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Beowulf <beowulf@beocode.eu> Co-committed-by: Beowulf <beowulf@beocode.eu>
* Make switch larger on touchscreen devices (#6546)0ko2025-01-131-2/+4
| | | | | | | | | | | | | | | | | | | | | | Followup to https://codeberg.org/forgejo/forgejo/pulls/6459. Usually it's quite hard to have inputs with balanced size that works for both desktop and mobile: it's either too large or too small for one of them. I think this can be a solution for this new element. I tried it locally, it feels good on a phone. There's likely one downside which is that the switch will still be larger on touch devices even when they're wide, like on tablets. I think it can be resolved separately at some point. It isn't a problem on small devices because usually these elements go on separate rows. ## Preview This change only affects touch devices. |Before|After| |-|-| |![](/attachments/75311c3f-2e19-4b03-9596-7f78c78f0a70)|![](/attachments/74f987af-57c1-417d-89ed-f96666cb9bad)| Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6546 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>
* Use redesigned switch on commit graph page (#6545)0ko2025-01-131-0/+8
| | | | | | | | | | | | | | | | | | | | [skip ci] no related tests (covered by visual testing only) Followup to https://codeberg.org/forgejo/forgejo/pulls/5214 and https://codeberg.org/forgejo/forgejo/pulls/6459. Resolves https://codeberg.org/forgejo/forgejo/issues/2852. ## Preview |Before|After| |-|-| |![](/attachments/c871bcdd-f60c-460f-93d8-33550b409d25)|![](/attachments/e97e63d8-2917-408d-87ce-37ee31dedc93)| Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6545 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>
* Use flex for switch items (#6544)0ko2025-01-131-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | [skip ci] no related tests (covered by visual testing only) Followup to https://codeberg.org/forgejo/forgejo/pulls/6459. More specifically, to https://codeberg.org/forgejo/forgejo/pulls/6459#issuecomment-2562521. Thanks, @viceice! I found a good reason to use `display: flex;` for the switch items: it prevents whitespaces between HTML tags from showing up between the icon and the text. I was wondering why the new switch is wider, now I noticed why while playing with it. Lack of this additional whitespace looks better and is consistent with most of the UI. ## Preview |Description|Image| |-|-| |The margin that's supposed to be (no whitespace)|![](https://codeberg.org/attachments/c0377eaa-7dec-4ef1-a4d6-70ad67608a8c)| |Redesigned switch before|![](https://codeberg.org/attachments/d05bb17a-7e5f-4356-9840-2682f5b31f8a)| |After|![](https://codeberg.org/attachments/b62c9373-395c-47a3-a8aa-b6905a22b11a)| Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6544 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>
* Prevent vertical stretching of the switch (#6543)0ko2025-01-131-0/+2
| | | | | | | | | | | | | | | | | | | | | Followup to https://codeberg.org/forgejo/forgejo/pulls/6459 and https://codeberg.org/forgejo/forgejo/pulls/6542. There are some edge cases where the UI would try to stretch the switch. Such inputs aren't really supposed to be dynamically stretched like this because it never looks good. So, I added a few rules to prevent this. ## Preview This is the edge case with an artificially narrow screen. |Before|After| |-|-| |![](/attachments/343d395c-54dd-4d86-a402-0c6b6a06237a)|![](/attachments/26b072a3-4056-4b1a-a08f-e903160609d9)| No visual changes are expected outside of such edge case. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6543 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>
* Fix minor misalignment (#6541)0ko2025-01-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | [skip ci] no relevant tests It's been there for a while. `flex-start` causes all items to stick to one side and be misaligned if they have different heights. `align-items` isn't actually needed in this area when the goal is centered vertical alignment, however, unsetting it _could_ break items' height. I couldn't make it do that, but to be safe I kept it and only replaced the value. ## Preview |![](/attachments/5ccf3c2d-c468-4524-84b4-efa3b3d5a60a)| |-| |![](/attachments/5ad079e9-5e22-4118-b1cd-492ad51f0371)| There's no difference when they're broken into two rows, on mobile. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6541 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>
* Update dependency happy-dom to v16 (forgejo) (#6454)Renovate Bot2025-01-071-4/+1
| | | | | Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
* Lock file maintenance (forgejo) (#6478)Renovate Bot2025-01-061-47/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR contains the following updates: | Update | Change | |---|---| | lockFileMaintenance | All locks refreshed | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * 1" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTAuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6478 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
* ui: switch redesign (#6459)0ko2025-01-052-0/+25
| | | | | Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6459 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
* Make new table modal work when editing a issueJakobDev2024-12-312-1/+4
|
* Merge pull request 'Fix edit cancel button' (#6421) from ↵Otto2024-12-311-2/+2
|\ | | | | | | | | | | | | | | JakobDev/forgejo:cancelfix into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6421 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Otto <otto@codeberg.org>
| * Fix edit cancel buttonJakobDev2024-12-301-2/+2
| |
* | Merge pull request 'Fix issue/comment menus' (#6419) from ↵Otto2024-12-301-1/+4
|\ \ | | | | | | | | | | | | | | | | | | fnetx/issue-view-a11y into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6419 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
| * | Fix issue/comment menusOtto Richter2024-12-301-1/+4
| |/ | | | | | | | | | | | | | | | | | | | | | | | | Closes https://codeberg.org/forgejo/forgejo/issues/1120 - Adds labels to reaction and context menu. - Fixes taborder in markdown combobox buttons. They are now only one "tab" stop and can be navigated with arrow buttons and in the right order (previously, it would skip the table button). - Generates more verbose output for the reactio selectors to provide content for users who cannot identify the meaning of these buttons visually. Explicit aria-labels are now preferred over auto-generated ones.
* / Rework user profile settingsOtto Richter2024-12-303-31/+20
|/ | | | | | | | | | | | | | | | | | | | | | Accessibility: - improved semantic layout - Fixes unlabelled input for custom pronouns. CC @hazy - Adds labels to dropdowns. - Shortens certain texts for less verbose screen reader outputs and people with slow reading speed. - Turned optional username rename helper text with low contrast into "normal" help text. UI/UX: - Removes section about primary email which is no longer managed in the profile section. - Fixes section about primary email not displaying in user settings when notifications are not available. - Removes primary email display, because it is not actually a form element here. (Alternatively, we could display it and link to the account settings for managing the email)
* Merge pull request 'feat: add synchronization for SSH keys for OpenID ↵Gusted2024-12-291-1/+5
|\ | | | | | | | | | | | | Connect' (#6232) from Maks1mS/forgejo:feat/add-oidc-ssh-keys into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6232 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
| * Merge branch 'forgejo' into feat/add-oidc-ssh-keysMaks1mS2024-12-265-75/+148
| |\
| * \ Merge remote-tracking branch 'upstream/forgejo' into feat/add-oidc-ssh-keysMaxim Slipenko2024-12-198-37/+41
| |\ \
| * \ \ Merge branch 'forgejo' into feat/add-oidc-ssh-keysMaks1mS2024-12-101-3/+3
| |\ \ \
| * | | | feat: add synchronization for SSH keys with OpenID ConnectMaxim Slipenko2024-12-091-1/+5
| | | | | | | | | | | | | | | | | | | | Co-authored-by: Kirill Kolmykov <cyberk1ra@ya.ru>
* | | | | Merge pull request 'Cosmetic changes and fixes around repo homepage' (#6401) ↵Otto2024-12-291-3/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from 0ko/forgejo:ui-repo-meta-2 into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6401 Reviewed-by: Otto <otto@codeberg.org>
| * | | | | ui: cosmetic changes and fixes around repo homepage0ko2024-12-291-3/+4
| | |_|_|/ | |/| | |
* / | | | New repo: Clean up and improve CSSOtto Richter2024-12-283-107/+110
|/ / / / | | | | | | | | | | | | | | | | | | | | - drop custom layout rules for this page - move form-related content to form.css - extend new form CSS to add gap between labels and input fields
* | | | Merge pull request '[gitea] week 2024-52 cherry pick (gitea/main -> ↵Earl Warren2024-12-243-3/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | forgejo)' (#6342) from earl-warren/wcp/2024-52 into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6342 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
| * | | | Fix incomplete Actions status aggregations (#32859)wxiaoguang2024-12-223-3/+8
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix #32857 (cherry picked from commit d28a4843b8de5d5e01ef3d7b2ad25f22853247ad) Conflicts: web_src/js/components/ActionRunStatus.vue remove the refactoring, keep the additional cancelled status
* | | | Lock file maintenanceRenovate Bot2024-12-231-69/+121
| | | |
* | | | feat(ui): show repo size on mobile (#6344)0ko2024-12-221-3/+14
| | | | | | | | | | | | | | | | | | | | Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6344 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
* | | | feat: filepath filter for code search (#6143)Shiny Nematoda2024-12-221-0/+5
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | Added support for searching content in a specific directory or file. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6143 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: 0ko <0ko@noreply.codeberg.org> Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com> Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
* | | Merge pull request '[gitea] week 2024-51 cherry pick (gitea/main -> ↵Earl Warren2024-12-191-1/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | forgejo)' (#6271) from earl-warren/wcp/2024-51 into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6271 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
| * | | Detect whether action view branch was deleted (#32764)Lunny Xiao2024-12-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix #32761 ![图片](https://github.com/user-attachments/assets/a5a7eef8-0fea-4242-b199-1b0b73d9bbdb) (cherry picked from commit 6370d2fb93a5ee897b82969ca30a9feb33667714) Conflicts: routers/web/repo/actions/actions.go routers/web/repo/actions/view.go trivial context conflicts
* | | | chore: Update katex import pathGusted2024-12-181-1/+1
| | | |
* | | | Merge pull request '[gitea] Add links to commit lists in contributors graph ↵Otto2024-12-162-3/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | page (#32799)' (#6274) from wetneb/forgejo:gitea_contributor_link into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6274 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: 0ko <0ko@noreply.codeberg.org> Reviewed-by: Otto <otto@codeberg.org>
| * | | | Add "n commits" link to contributors in contributors graph page (#32799)Chai-Shi2024-12-152-3/+23
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes Issue #29365 and inherit PR #29429 - I should extend the #29429 fork but the fork is not synced, so I created another PR. - Use `silenced` class for the link, as in #29847 --------- Co-authored-by: Ben Chang <ben_chang@htc.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* | | | Merge pull request 'Put issue actions in a single row on mobile' (#6044) ↵Otto2024-12-163-31/+14
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | from 0ko/forgejo:ui-commenting-singlerow into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6044 Reviewed-by: Otto <otto@codeberg.org>
| * | | fix(ui): put buttons in a single row on mobile0ko2024-11-253-31/+14
| | | |
* | | | Merge pull request 'Simplify main-attribute labels' (#6201) from ↵Otto2024-12-131-1/+1
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | 0ko/forgejo:ui-simple-spec-labels into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6201 Reviewed-by: Otto <otto@codeberg.org>
| * | | ui: simplify main-attribute labels0ko2024-12-081-1/+1
| | |/ | |/|
* / | fix: render job title as commit message (#32748)metiftikci2024-12-081-3/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | resolves #32724 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit ad994780af48e2aff27b0e7e496fd559dc0fe3fc) Conflicts: routers/web/repo/actions/view.go because of RenderCommitMessage context
* | Fix bug where Action UI may occasionally not load logs (#6122)Mathieu Fenniak2024-12-052-12/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the combination of events where the user is viewing an action that is completed (and therefore no interval-based loading of logs is occurring), and `loadJob` is called while `loadJob` is already running (commonly from expanding two log sections back-to-back), the second request for loading would be discarded and never occur. To fix this, the invocation of `loadJob` keeps track of the log cursors it is attempting to load, and an aborted invocation stores its attempted load. If `loadJob` succeeds in loading and finds that an attempt was aborted while it was busy, it will reload the data. Steps to reproduce: - Open an Action UI that is already "Done". - Click on two steps in rapid succession to expand their logs. - (Race condition) As long as the second click is registered while the first log chunk is being loaded, its data won't load. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... (**not applicable**) - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [x] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6122 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
* | Lock file maintenanceRenovate Bot2024-12-041-29/+35
| |