diff options
author | Sindhu Parvathi Gopinathan <sgopinathan@nvidia.com> | 2023-03-20 13:15:03 +0100 |
---|---|---|
committer | Chirag Shah <chirag@nvidia.com> | 2023-03-21 03:17:32 +0100 |
commit | 463110f7335632d03557f1c5bfdd066b170011a8 (patch) | |
tree | 9b044583f75f66253f89ac0ab4c6e33dcffe40b9 | |
parent | Merge pull request #12688 from dorDiogo/isis_hello_padding_sometimes (diff) | |
download | frr-463110f7335632d03557f1c5bfdd066b170011a8.tar.xz frr-463110f7335632d03557f1c5bfdd066b170011a8.zip |
lib:fix clear route-map cmd using DEFPY
Due to the wrong input argv id, "argv[idx_word]->arg"
fetched in-correctly and it clears all the route-maps instead of
specific one.
Now correct argv id is passed to clear the given route-map counters.
Also, use RMAP_NAME which allows to show list of configured
route-maps in the system.
After Fix:-
Ticket:#3407773
Issue:3407773
Testing: UT done
Before:
TORC11# clear route-map counters
<cr>
WORD route-map name
After:
TORC11# clear route-map counters
<cr>
RMAP_NAME route-map name
my-as
Signed-off-by: Chirag Shah <chirag@nvidia.com>
Signed-off-by: Sindhu Parvathi Gopinathan's <sgopinathan@nvidia.com>
-rw-r--r-- | lib/routemap.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/lib/routemap.c b/lib/routemap.c index 9f5c9e693..16da81fa7 100644 --- a/lib/routemap.c +++ b/lib/routemap.c @@ -3101,27 +3101,24 @@ static void clear_route_map_helper(struct route_map *map) index->applied_clear = index->applied; } -DEFUN (rmap_clear_counters, +DEFPY (rmap_clear_counters, rmap_clear_counters_cmd, - "clear route-map counters [WORD]", + "clear route-map counters [RMAP_NAME$rmapname]", CLEAR_STR "route-map information\n" "counters associated with the specified route-map\n" "route-map name\n") { - int idx_word = 2; struct route_map *map; - const char *name = (argc == 3 ) ? argv[idx_word]->arg : NULL; - - if (name) { - map = route_map_lookup_by_name(name); + if (rmapname) { + map = route_map_lookup_by_name(rmapname); if (map) clear_route_map_helper(map); else { vty_out(vty, "%s: 'route-map %s' not found\n", - frr_protonameinst, name); + frr_protonameinst, rmapname); return CMD_SUCCESS; } } else { |