diff options
| author | Donald Sharp <sharpd@nvidia.com> | 2023-01-30 22:02:23 +0100 |
|---|---|---|
| committer | Donald Sharp <sharpd@nvidia.com> | 2023-01-30 22:02:23 +0100 |
| commit | 367b458cb444d005a6fc4606dcf7aca31c16e848 (patch) | |
| tree | 5618d2ab48097f9a7c8992a95384da4bd3d241ec /bgpd/bgp_mac.c | |
| parent | Merge pull request #12700 from taspelund/martian_tip_improvement (diff) | |
| download | frr-367b458cb444d005a6fc4606dcf7aca31c16e848.tar.xz frr-367b458cb444d005a6fc4606dcf7aca31c16e848.zip | |
bgpd: bgp_update and bgp_withdraw never return failures
These two functions always return 0. As such any and all
tests against this make no sense. Remove the return 0
to a void and follow the chain, logically, to remove all
the dead code.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'bgpd/bgp_mac.c')
| -rw-r--r-- | bgpd/bgp_mac.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/bgpd/bgp_mac.c b/bgpd/bgp_mac.c index b9649ac4d..52ffb1033 100644 --- a/bgpd/bgp_mac.c +++ b/bgpd/bgp_mac.c @@ -211,16 +211,10 @@ static void bgp_process_mac_rescan_table(struct bgp *bgp, struct peer *peer, memcpy(&evpn, bgp_attr_get_evpn_overlay(pi->attr), sizeof(evpn)); - int32_t ret = bgp_update(peer, p, - pi->addpath_rx_id, - pi->attr, AFI_L2VPN, SAFI_EVPN, - ZEBRA_ROUTE_BGP, - BGP_ROUTE_NORMAL, &prd, - label_pnt, num_labels, - 1, evpn); - - if (ret < 0) - bgp_dest_unlock_node(dest); + bgp_update(peer, p, pi->addpath_rx_id, pi->attr, + AFI_L2VPN, SAFI_EVPN, ZEBRA_ROUTE_BGP, + BGP_ROUTE_NORMAL, &prd, label_pnt, + num_labels, 1, evpn); } } } |