summaryrefslogtreecommitdiffstats
path: root/bgpd/bgp_updgrp.c
diff options
context:
space:
mode:
authorDonatas Abraitis <donatas@opensourcerouting.org>2023-07-07 22:39:44 +0200
committerDonatas Abraitis <donatas@opensourcerouting.org>2023-07-07 22:41:43 +0200
commitc76f6146ab0b3383e000ffffe693dabfaf5d1439 (patch)
tree32e0a4d7bcdf525fbd7185a5fd6777074ccd7d7f /bgpd/bgp_updgrp.c
parentMerge pull request #13949 from opensourcerouting/fix/bgpd_deprecations (diff)
downloadfrr-c76f6146ab0b3383e000ffffe693dabfaf5d1439.tar.xz
frr-c76f6146ab0b3383e000ffffe693dabfaf5d1439.zip
bgpd: Deprecate Prestandard Outbound Route Filtering capability
https://www.rfc-editor.org/rfc/rfc8810.html Not relevant anymore. Use RFC'd version of ORF. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Diffstat (limited to 'bgpd/bgp_updgrp.c')
-rw-r--r--bgpd/bgp_updgrp.c25
1 files changed, 9 insertions, 16 deletions
diff --git a/bgpd/bgp_updgrp.c b/bgpd/bgp_updgrp.c
index 0fe6180be..849f66993 100644
--- a/bgpd/bgp_updgrp.c
+++ b/bgpd/bgp_updgrp.c
@@ -420,8 +420,6 @@ static unsigned int updgrp_hash_key_make(const void *p)
*/
if (CHECK_FLAG(peer->flags, PEER_FLAG_LONESOUL)
|| CHECK_FLAG(peer->af_cap[afi][safi], PEER_CAP_ORF_PREFIX_SM_RCV)
- || CHECK_FLAG(peer->af_cap[afi][safi],
- PEER_CAP_ORF_PREFIX_SM_OLD_RCV)
|| CHECK_FLAG(peer->af_flags[afi][safi], PEER_FLAG_MAX_PREFIX_OUT))
key = jhash_1word(jhash(peer->host, strlen(peer->host), SEED2),
key);
@@ -492,15 +490,12 @@ static unsigned int updgrp_hash_key_make(const void *p)
: "(NONE)",
peer->shared_network &&
peer_afi_active_nego(peer, AFI_IP6));
- zlog_debug(
- "%pBP Update Group Hash: Lonesoul: %d ORF prefix: %u ORF old: %u max prefix out: %ju",
- peer, !!CHECK_FLAG(peer->flags, PEER_FLAG_LONESOUL),
- CHECK_FLAG(peer->af_cap[afi][safi],
- PEER_CAP_ORF_PREFIX_SM_RCV),
- CHECK_FLAG(peer->af_cap[afi][safi],
- PEER_CAP_ORF_PREFIX_SM_OLD_RCV),
- (intmax_t)CHECK_FLAG(peer->af_flags[afi][safi],
- PEER_FLAG_MAX_PREFIX_OUT));
+ zlog_debug("%pBP Update Group Hash: Lonesoul: %d ORF prefix: %u max prefix out: %ju",
+ peer, !!CHECK_FLAG(peer->flags, PEER_FLAG_LONESOUL),
+ CHECK_FLAG(peer->af_cap[afi][safi],
+ PEER_CAP_ORF_PREFIX_SM_RCV),
+ (intmax_t)CHECK_FLAG(peer->af_flags[afi][safi],
+ PEER_FLAG_MAX_PREFIX_OUT));
zlog_debug(
"%pBP Update Group Hash: local role: %u AIGP: %d SOO: %s",
peer, peer->local_role,
@@ -637,11 +632,9 @@ static bool updgrp_hash_cmp(const void *p1, const void *p2)
if ((afi == AFI_IP6) && (pe1->shared_network != pe2->shared_network))
return false;
- if ((CHECK_FLAG(pe1->flags, PEER_FLAG_LONESOUL)
- || CHECK_FLAG(pe1->af_cap[afi][safi], PEER_CAP_ORF_PREFIX_SM_RCV)
- || CHECK_FLAG(pe1->af_cap[afi][safi],
- PEER_CAP_ORF_PREFIX_SM_OLD_RCV))
- && !sockunion_same(&pe1->su, &pe2->su))
+ if ((CHECK_FLAG(pe1->flags, PEER_FLAG_LONESOUL) ||
+ CHECK_FLAG(pe1->af_cap[afi][safi], PEER_CAP_ORF_PREFIX_SM_RCV)) &&
+ !sockunion_same(&pe1->su, &pe2->su))
return false;
return true;