diff options
author | Donald Sharp <sharpd@nvidia.com> | 2023-03-27 14:08:36 +0200 |
---|---|---|
committer | Donald Sharp <sharpd@nvidia.com> | 2023-03-27 14:08:36 +0200 |
commit | 38c57f3f655a13bd4362e653d7a1ff73ba35ab66 (patch) | |
tree | f2c327eafd5a68ed5a307ee739196d1d240e8d9b /lib/mgmt_fe_client.c | |
parent | Merge pull request #12931 from SaiGomathiN/yang (diff) | |
download | frr-38c57f3f655a13bd4362e653d7a1ff73ba35ab66.tar.xz frr-38c57f3f655a13bd4362e653d7a1ff73ba35ab66.zip |
lib: Remove unneeded asserts in mgmt code
event_add_XXXX functions have no failure path where
if you pass in a double event pointer that it could
return without setting the pointer. As such these
asserts make no sense and are unnecessary
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'lib/mgmt_fe_client.c')
-rw-r--r-- | lib/mgmt_fe_client.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/lib/mgmt_fe_client.c b/lib/mgmt_fe_client.c index 57c1961ff..a2c4fd657 100644 --- a/lib/mgmt_fe_client.c +++ b/lib/mgmt_fe_client.c @@ -741,27 +741,23 @@ mgmt_fe_client_register_event(struct mgmt_fe_client_ctx *client_ctx, event_add_read(client_ctx->tm, mgmt_fe_client_read, client_ctx, client_ctx->conn_fd, &client_ctx->conn_read_ev); - assert(client_ctx->conn_read_ev); break; case MGMTD_FE_CONN_WRITE: event_add_write(client_ctx->tm, mgmt_fe_client_write, client_ctx, client_ctx->conn_fd, &client_ctx->conn_write_ev); - assert(client_ctx->conn_write_ev); break; case MGMTD_FE_PROC_MSG: tv.tv_usec = MGMTD_FE_MSG_PROC_DELAY_USEC; event_add_timer_tv(client_ctx->tm, mgmt_fe_client_proc_msgbufs, client_ctx, &tv, &client_ctx->msg_proc_ev); - assert(client_ctx->msg_proc_ev); break; case MGMTD_FE_CONN_WRITES_ON: event_add_timer_msec( client_ctx->tm, mgmt_fe_client_resume_writes, client_ctx, MGMTD_FE_MSG_WRITE_DELAY_MSEC, &client_ctx->conn_writes_on); - assert(client_ctx->conn_writes_on); break; case MGMTD_FE_SERVER: assert(!"mgmt_fe_client_ctx_post_event called incorrectly"); |