diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2018-08-20 20:05:53 +0200 |
|---|---|---|
| committer | Quentin Young <qlyoung@cumulusnetworks.com> | 2018-09-06 22:50:58 +0200 |
| commit | 266469ebababa2d6949bbd22390010d422a68356 (patch) | |
| tree | a5b15fdf7d24d393645d2e898350a87a5b59f9d8 /ospfd/ospf_lsdb.c | |
| parent | lib: Modify zlog_warn to vty_out (diff) | |
| download | frr-266469ebababa2d6949bbd22390010d422a68356.tar.xz frr-266469ebababa2d6949bbd22390010d422a68356.zip | |
ospfd: Cleanup some warnings that were not warnings
1) stream allocation cannot fail
2) some warnings were removed when functions safely ignored
the calling parameters being wrong.
3) some warnings were removed when functions did not consider
the state as an error since we did not return an error code.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'ospfd/ospf_lsdb.c')
| -rw-r--r-- | ospfd/ospf_lsdb.c | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/ospfd/ospf_lsdb.c b/ospfd/ospf_lsdb.c index ef965a5f9..f39bea976 100644 --- a/ospfd/ospf_lsdb.c +++ b/ospfd/ospf_lsdb.c @@ -142,19 +142,8 @@ void ospf_lsdb_delete(struct ospf_lsdb *lsdb, struct ospf_lsa *lsa) struct prefix_ls lp; struct route_node *rn; - if (!lsdb) { - zlog_warn("%s: Called with NULL LSDB", __func__); - if (lsa) - zlog_warn("LSA[Type%d:%s]: LSA %p, lsa->lsdb %p", - lsa->data->type, inet_ntoa(lsa->data->id), - (void *)lsa, (void *)lsa->lsdb); + if (!lsdb || !lsa) return; - } - - if (!lsa) { - zlog_warn("%s: Called with NULL LSA", __func__); - return; - } assert(lsa->data->type < OSPF_MAX_LSA); table = lsdb->type[lsa->data->type].db; |