diff options
| author | Donald Sharp <sharpd@cumulusnetwroks.com> | 2016-05-15 19:41:23 +0200 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2016-05-20 15:34:32 +0200 |
| commit | cb2af5d07aa71150113ec28ad1945ef9ee8546ae (patch) | |
| tree | f614f39d46e043dae6d0e140e3941b0028308e04 /ospfd/ospf_packet.c | |
| parent | isisd: Remove dead case (diff) | |
| download | frr-cb2af5d07aa71150113ec28ad1945ef9ee8546ae.tar.xz frr-cb2af5d07aa71150113ec28ad1945ef9ee8546ae.zip | |
ospfd: Fix compiler warnings
Two issues:
1) nbr->oi->ifp->name is an array it would
always evaluate to true.
2) There exist a code path where addr
would be used without initialization.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>
Diffstat (limited to 'ospfd/ospf_packet.c')
| -rw-r--r-- | ospfd/ospf_packet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ospfd/ospf_packet.c b/ospfd/ospf_packet.c index 8bf07783e..f58044411 100644 --- a/ospfd/ospf_packet.c +++ b/ospfd/ospf_packet.c @@ -4022,7 +4022,7 @@ ospf_proactively_arp (struct ospf_neighbor *nbr) char *str_ptr; int ret; - if (!nbr || !nbr->oi || !nbr->oi->ifp || !nbr->oi->ifp->name) + if (!nbr || !nbr->oi || !nbr->oi->ifp) return; str_ptr = strcpy (ping_nbr, "ping -c 1 -I "); |