summaryrefslogtreecommitdiffstats
path: root/tests/topotests/bgp_multiview_topo1
diff options
context:
space:
mode:
authorMartin Winter <mwinter@opensourcerouting.org>2017-05-20 05:41:20 +0200
committerDonald Sharp <sharpd@cumulusnetworks.com>2018-11-28 02:22:11 +0100
commit7e7fc73b49d9ea90bdb3f5821592f832056f336f (patch)
treef90a98d8f875dd5398de651d834fb49405072c45 /tests/topotests/bgp_multiview_topo1
parentlib: Add different failure comment on processes killed by AddressSanitizer (diff)
downloadfrr-7e7fc73b49d9ea90bdb3f5821592f832056f336f.tar.xz
frr-7e7fc73b49d9ea90bdb3f5821592f832056f336f.zip
(all tests): Add extra check to make sure daemons are still running after each essential stage.
If daemon crashed at a later stage (not startup), then the test scripts didn't properly detect it and report unpredictable errors. This will properly log the daemon crashes Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Diffstat (limited to 'tests/topotests/bgp_multiview_topo1')
-rwxr-xr-xtests/topotests/bgp_multiview_topo1/test_bgp_multiview_topo1.py10
1 files changed, 10 insertions, 0 deletions
diff --git a/tests/topotests/bgp_multiview_topo1/test_bgp_multiview_topo1.py b/tests/topotests/bgp_multiview_topo1/test_bgp_multiview_topo1.py
index 8c33156aa..d7c350f5e 100755
--- a/tests/topotests/bgp_multiview_topo1/test_bgp_multiview_topo1.py
+++ b/tests/topotests/bgp_multiview_topo1/test_bgp_multiview_topo1.py
@@ -251,6 +251,11 @@ def test_bgp_converge():
# print("\nwaiting 15s for routes to populate")
# sleep(15)
+ # Make sure that all daemons are running
+ for i in range(1, 2):
+ fatal_error = net['r%s' % i].checkRouterRunning()
+ assert fatal_error == "", fatal_error
+
# For debugging after starting Quagga/FRR daemons, uncomment the next line
# CLI(net)
@@ -307,6 +312,11 @@ def test_bgp_routingTable():
assert failures == 0, "Routing Table verification failed for router r%s, view %s:\n%s" % (i, view, diff)
+ # Make sure that all daemons are running
+ for i in range(1, 2):
+ fatal_error = net['r%s' % i].checkRouterRunning()
+ assert fatal_error == "", fatal_error
+
# For debugging after starting FRR/Quagga daemons, uncomment the next line
# CLI(net)