summaryrefslogtreecommitdiffstats
path: root/tests/topotests/lib
diff options
context:
space:
mode:
authorKuldeep Kashyap <kashyapk@vmware.com>2022-05-16 12:28:02 +0200
committerKuldeep Kashyap <kashyapk@vmware.com>2022-05-16 12:28:02 +0200
commit58cfbb272d07ac5056e43016170b3b19087923ef (patch)
treebfdf110e2842b16cb79070cf467fd5ca7404aac7 /tests/topotests/lib
parentMerge pull request #11207 from anlancs/fix/zebra-remove-check-l3vni (diff)
downloadfrr-58cfbb272d07ac5056e43016170b3b19087923ef.tar.xz
frr-58cfbb272d07ac5056e43016170b3b19087923ef.zip
tests: Fix for test_pim_dr_nondr_with_ospf_topo2 test failure
This test is failing intermittently because sometimes igmp local join is not getting deleted. I did split the joins means trying to delete igmp local joins one by one. I tried running tests multiple times and it seems to be working fine with current changes. There was an issue found during debugging this test failure, which was raised already: Issue# https://github.com/FRRouting/frr/issues/11105 Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
Diffstat (limited to 'tests/topotests/lib')
-rw-r--r--tests/topotests/lib/pim.py8
1 files changed, 5 insertions, 3 deletions
diff --git a/tests/topotests/lib/pim.py b/tests/topotests/lib/pim.py
index 47892a521..b0889373c 100644
--- a/tests/topotests/lib/pim.py
+++ b/tests/topotests/lib/pim.py
@@ -273,18 +273,20 @@ def create_igmp_config(tgen, topo, input_dict=None, build=False):
config_data.append(cmd)
protocol = "igmp"
del_action = intf_data[intf_name]["igmp"].setdefault("delete", False)
+ del_attr = intf_data[intf_name]["igmp"].setdefault("delete_attr", False)
cmd = "ip igmp"
if del_action:
cmd = "no {}".format(cmd)
- config_data.append(cmd)
+ if not del_attr:
+ config_data.append(cmd)
- del_attr = intf_data[intf_name]["igmp"].setdefault("delete_attr", False)
for attribute, data in intf_data[intf_name]["igmp"].items():
if attribute == "version":
cmd = "ip {} {} {}".format(protocol, attribute, data)
if del_action:
cmd = "no {}".format(cmd)
- config_data.append(cmd)
+ if not del_attr:
+ config_data.append(cmd)
if attribute == "join":
for group in data: