diff options
| author | Denton Liu <liu.denton@gmail.com> | 2020-03-26 09:27:51 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-03-27 18:56:40 +0100 |
| commit | 5a828bcf1e1a3152f31c90bcf6557ba8d7b0459f (patch) | |
| tree | d63d58bac856326b124d2d1726605639e8ecb93d | |
| parent | t5512: stop losing return codes of git commands (diff) | |
| download | git-5a828bcf1e1a3152f31c90bcf6557ba8d7b0459f.tar.xz git-5a828bcf1e1a3152f31c90bcf6557ba8d7b0459f.zip | |
t5550: simplify no matching line check
In the 'did not use upload-pack service' test, we have a complicated
song-and-dance to ensure that there are no "/git-upload-pack" lines in
"$HTTPD_ROOT_PATH/access.log". Simplify this by just checking that grep
returns a non-zero exit code.
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t5550-http-fetch-dumb.sh | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh index b811d89cfd..bcde886b87 100755 --- a/t/t5550-http-fetch-dumb.sh +++ b/t/t5550-http-fetch-dumb.sh @@ -248,9 +248,7 @@ test_expect_success 'fetch can handle previously-fetched .idx files' ' ' test_expect_success 'did not use upload-pack service' ' - test_might_fail grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act && - : >exp && - test_cmp exp act + ! grep "/git-upload-pack" "$HTTPD_ROOT_PATH/access.log" ' test_expect_success 'git client shows text/plain errors' ' |