summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDerrick Stolee <dstolee@microsoft.com>2020-04-09 15:00:11 +0200
committerJunio C Hamano <gitster@pobox.com>2020-04-09 20:04:35 +0200
commitcaf388caa101be90b7ec43d7f78ca4e935fc0150 (patch)
treeddb2c2a65d6994420c076140600c568a7740429b
parentcommit-graph: add GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS test flag (diff)
downloadgit-caf388caa101be90b7ec43d7f78ca4e935fc0150.tar.xz
git-caf388caa101be90b7ec43d7f78ca4e935fc0150.zip
bloom: ignore renames when computing changed paths
The changed-path Bloom filters record an entry in the filter for every path that was changed. This includes every add and delete, regardless of whether a rename was detected. Detecting renames causes significant performance issues, but also will trigger downloading missing blobs in partial clone. The simple fix is to disable rename detection when computing a changed-path Bloom filter. This should already be disabled by default, but it is good to explicitly enforce the intended behavior. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--bloom.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/bloom.c b/bloom.c
index c5b461d1cf..dd9bab9bbd 100644
--- a/bloom.c
+++ b/bloom.c
@@ -189,6 +189,7 @@ struct bloom_filter *get_bloom_filter(struct repository *r,
repo_diff_setup(r, &diffopt);
diffopt.flags.recursive = 1;
+ diffopt.detect_rename = 0;
diffopt.max_changes = max_changes;
diff_setup_done(&diffopt);