diff options
| author | Jeff King <peff@peff.net> | 2019-02-06 20:18:58 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-02-06 21:20:22 +0100 |
| commit | cbdb8d14392690f2e540b9efdb245871a043eb06 (patch) | |
| tree | 609be1ffc8bd2f7c08727ec9ed8767fec909f7c5 | |
| parent | remote-curl: refactor smart-http discovery (diff) | |
| download | git-cbdb8d14392690f2e540b9efdb245871a043eb06.tar.xz git-cbdb8d14392690f2e540b9efdb245871a043eb06.zip | |
remote-curl: tighten "version 2" check for smart-http
In a v2 smart-http conversation, the server should reply to our initial
request with a pkt-line saying "version 2". We check that with
starts_with(), but really that should be the only thing in that packet.
A response of "version 20" should not match.
Let's tighten this check to use strcmp(). Note that we don't need to
worry about a trailing newline here, because the ptk-line code will have
chomped it for us already.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | remote-curl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/remote-curl.c b/remote-curl.c index c78ba83744..bb7421023b 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -374,7 +374,7 @@ static void check_smart_http(struct discovery *d, const char *service, d->len = reader.src_len; d->proto_git = 1; - } else if (starts_with(reader.line, "version 2")) { + } else if (!strcmp(reader.line, "version 2")) { /* * v2 smart http; do not consume version packet, which will * be handled elsewhere. |