diff options
| author | Junio C Hamano <gitster@pobox.com> | 2022-06-08 23:27:53 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-06-08 23:27:53 +0200 |
| commit | d2b11e05e0293befe7d6ef58fb4bb0fb65ec468a (patch) | |
| tree | 9e8444977d91671638244ced19fec7a118e153ab | |
| parent | Merge branch 'ds/midx-normalize-pathname-before-comparison' into maint (diff) | |
| parent | clone: plug a miniscule leak (diff) | |
| download | git-d2b11e05e0293befe7d6ef58fb4bb0fb65ec468a.tar.xz git-d2b11e05e0293befe7d6ef58fb4bb0fb65ec468a.zip | |
Merge branch 'jc/clone-remote-name-leak-fix' into maint
"git clone --origin X" leaked piece of memory that held value read
from the clone.defaultRemoteName configuration variable, which has
been plugged.
source: <xmqqlevl4ysk.fsf@gitster.g>
* jc/clone-remote-name-leak-fix:
clone: plug a miniscule leak
| -rw-r--r-- | builtin/clone.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/builtin/clone.c b/builtin/clone.c index 5231656379..194d50f75f 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -1106,8 +1106,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix) * apply the remote name provided by --origin only after this second * call to git_config, to ensure it overrides all config-based values. */ - if (option_origin != NULL) + if (option_origin != NULL) { + free(remote_name); remote_name = xstrdup(option_origin); + } if (remote_name == NULL) remote_name = xstrdup("origin"); |