diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-08-01 12:38:30 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-08-01 17:47:35 +0200 |
| commit | ed041007f09f34585db3e248082e8c7083c257dc (patch) | |
| tree | e83b6e706dc9df00f54a376adc1a57f4efff609a | |
| parent | builtin/describe: fix leaking array when running diff-index (diff) | |
| download | git-ed041007f09f34585db3e248082e8c7083c257dc.tar.xz git-ed041007f09f34585db3e248082e8c7083c257dc.zip | |
builtin/describe: fix trivial memory leak when describing blob
We never free the `struct strvec args` variable in `describe_blob()`,
which thus causes a memory leak. Fix this.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/describe.c | 1 | ||||
| -rwxr-xr-x | t/t9903-bash-prompt.sh | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/builtin/describe.c b/builtin/describe.c index 2957ff7031..954929c514 100644 --- a/builtin/describe.c +++ b/builtin/describe.c @@ -529,6 +529,7 @@ static void describe_blob(struct object_id oid, struct strbuf *dst) traverse_commit_list(&revs, process_commit, process_object, &pcd); reset_revision_walk(); release_revisions(&revs); + strvec_clear(&args); } static void describe(const char *arg, int last_one) diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh index d667dda654..95e9955bca 100755 --- a/t/t9903-bash-prompt.sh +++ b/t/t9903-bash-prompt.sh @@ -8,6 +8,7 @@ test_description='test git-specific bash prompt functions' GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME +TEST_PASSES_SANITIZE_LEAK=true . ./lib-bash.sh . "$GIT_BUILD_DIR/contrib/completion/git-prompt.sh" |