diff options
| author | Junio C Hamano <gitster@pobox.com> | 2022-09-15 18:06:57 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-09-15 20:34:51 +0200 |
| commit | fd01795beb1bda7aa738b443bcb01cc9df70059a (patch) | |
| tree | 66fceda921750dcac253ccdaa5d7e60f93ae792f | |
| parent | environ: explain Boolean environment variables (diff) | |
| download | git-fd01795beb1bda7aa738b443bcb01cc9df70059a.tar.xz git-fd01795beb1bda7aa738b443bcb01cc9df70059a.zip | |
environ: GIT_FLUSH should be made a usual Boolean
This uses atoi() and checks if the result is not zero to decide what
to do. Turning it into the usual Boolean environment variable to
use git_env_bool() would not break those who have been using "set to
0, or set to non-zero, that can be parsed with atoi()" values, but
will match the expectation of those who expected "true" to mean
"yes".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | Documentation/git.txt | 1 | ||||
| -rw-r--r-- | write-or-die.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/Documentation/git.txt b/Documentation/git.txt index 00ab9d7978..8159a4b3a4 100644 --- a/Documentation/git.txt +++ b/Documentation/git.txt @@ -705,6 +705,7 @@ for further details. waiting for someone with sufficient permissions to fix it. `GIT_FLUSH`:: +// NEEDSWORK: make it into a usual Boolean environment variable If this environment variable is set to "1", then commands such as 'git blame' (in incremental mode), 'git rev-list', 'git log', 'git check-attr' and 'git check-ignore' will diff --git a/write-or-die.c b/write-or-die.c index c4fd91b5b4..aaa0318e82 100644 --- a/write-or-die.c +++ b/write-or-die.c @@ -23,6 +23,7 @@ void maybe_flush_or_die(FILE *f, const char *desc) if (f == stdout) { if (skip_stdout_flush < 0) { + /* NEEDSWORK: make this a normal Boolean */ cp = getenv("GIT_FLUSH"); if (cp) skip_stdout_flush = (atoi(cp) == 0); |