summaryrefslogtreecommitdiffstats
path: root/Documentation/CodingGuidelines
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2020-03-29 05:06:53 +0200
committerJunio C Hamano <gitster@pobox.com>2020-03-29 17:41:54 +0200
commit78725ebda9577ec86a9657d20b8ee8c2a099601d (patch)
tree1436e8e1c1c92f239d31f105340941e93fba3195 /Documentation/CodingGuidelines
parentmsvc: accommodate for vcpkg's upgrade to OpenSSL v1.1.x (diff)
downloadgit-78725ebda9577ec86a9657d20b8ee8c2a099601d.tar.xz
git-78725ebda9577ec86a9657d20b8ee8c2a099601d.zip
CodingGuidelines: allow ${#posix} == strlen($posix)
The construct has been in POSIX for the past 10+ years, and we have used in t9xxx (subversion) series of the tests, so we know it is at portable across systems that people have run those tests, which is almost everything we'd care about. Let's loosen the rule; luckily, the check-non-portable-shell script does not have any rule to find its use, so the only change needed is a removal of one paragraph from the documentation. Helped-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/CodingGuidelines')
-rw-r--r--Documentation/CodingGuidelines2
1 files changed, 0 insertions, 2 deletions
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index f45db5b727..af50c707a9 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -91,8 +91,6 @@ For shell scripts specifically (not exhaustive):
- No shell arrays.
- - No strlen ${#parameter}.
-
- No pattern replacement ${parameter/pattern/string}.
- We use Arithmetic Expansion $(( ... )).