diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-04-13 22:01:34 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-04-14 08:56:08 +0200 |
| commit | bf20fe4ca8c8d2ba2087c9c44b4ee09a1d1467ed (patch) | |
| tree | 08636c2ac7c428086e6ad0324f4f7d7703e82e86 /builtin/rev-list.c | |
| parent | format-patch: don't leak "extra_headers" or "ref_message_ids" (diff) | |
| download | git-bf20fe4ca8c8d2ba2087c9c44b4ee09a1d1467ed.tar.xz git-bf20fe4ca8c8d2ba2087c9c44b4ee09a1d1467ed.zip | |
cocci: add and apply free_commit_list() rules
Add and apply coccinelle rules to remove "if (E)" before
"free_commit_list(E)", the function can accept NULL, and further
change cases where "E = NULL" followed to also be unconditionally.
The code changes in this commit were entirely made by the coccinelle
rule being added here, and applied with:
make contrib/coccinelle/free.cocci.patch
patch -p1 <contrib/coccinelle/free.cocci.patch
The only manual intervention here is that the the relevant code in
commit.c has been manually re-indented.
Suggested-by: Phillip Wood <phillip.wood123@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/rev-list.c')
| -rw-r--r-- | builtin/rev-list.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/builtin/rev-list.c b/builtin/rev-list.c index 572da1472e..07c0ad11d8 100644 --- a/builtin/rev-list.c +++ b/builtin/rev-list.c @@ -213,10 +213,8 @@ static void show_commit(struct commit *commit, void *data) static void finish_commit(struct commit *commit) { - if (commit->parents) { - free_commit_list(commit->parents); - commit->parents = NULL; - } + free_commit_list(commit->parents); + commit->parents = NULL; free_commit_buffer(the_repository->parsed_objects, commit); } |