diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2024-02-23 09:34:24 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-02-23 19:19:40 +0100 |
| commit | 5aca024a74e900bd9bc2c14a8e99494063ea4cc5 (patch) | |
| tree | ecbe991480dc8192c841abb243d4a174b0b38f68 /cache-tree.c | |
| parent | Always check `parse_tree*()`'s return value (diff) | |
| download | git-5aca024a74e900bd9bc2c14a8e99494063ea4cc5.tar.xz git-5aca024a74e900bd9bc2c14a8e99494063ea4cc5.zip | |
cache-tree: avoid an unnecessary check
The first thing the `parse_tree()` function does is to return early if
the tree has already been parsed. Therefore we do not need to guard the
`parse_tree()` call behind a check of that flag.
As of time of writing, there are no other instances of this in Git's
code bases: whenever the `parsed` flag guards a `parse_tree()` call, it
guards more than just that call.
Suggested-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'cache-tree.c')
| -rw-r--r-- | cache-tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cache-tree.c b/cache-tree.c index c6508b64a5..78d6ba9285 100644 --- a/cache-tree.c +++ b/cache-tree.c @@ -779,7 +779,7 @@ static void prime_cache_tree_rec(struct repository *r, struct cache_tree_sub *sub; struct tree *subtree = lookup_tree(r, &entry.oid); - if (!subtree->object.parsed && parse_tree(subtree) < 0) + if (parse_tree(subtree) < 0) exit(128); sub = cache_tree_sub(it, entry.path); sub->cache_tree = cache_tree(); |