diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-10-21 21:58:00 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-10-22 01:17:57 +0200 |
| commit | ebeb39faad6e3a67c31884c3dc6b76ce58b3f15b (patch) | |
| tree | 1139ff6cd0221247f64c16a9f4d4180cdcfdfe26 /config.mak.uname | |
| parent | git-sh-setup: remove unused sane_egrep() function (diff) | |
| download | git-ebeb39faad6e3a67c31884c3dc6b76ce58b3f15b.tar.xz git-ebeb39faad6e3a67c31884c3dc6b76ce58b3f15b.zip | |
git-sh-setup: remove "sane_grep", it's not needed anymore
Remove the sane_grep() shell function in git-sh-setup. The two reasons
for why it existed don't apply anymore:
1. It was added due to GNU grep supporting GREP_OPTIONS. See
e1622bfcbad (Protect scripted Porcelains from GREP_OPTIONS insanity,
2009-11-23).
Newer versions of GNU grep ignore that, but even on older versions
its existence won't matter, none of these sane_grep() uses care
about grep's output, they're merely using it to check if a string
exists in a file or stream. We also don't care about the "LC_ALL=C"
that "sane_grep" was using, these greps for fixed or ASCII strings
will behave the same under any locale.
2. The SANE_TEXT_GREP added in 71b401032b9 (sane_grep: pass "-a" if
grep accepts it, 2016-03-08) isn't needed either, none of these grep
uses deal with binary data.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'config.mak.uname')
| -rw-r--r-- | config.mak.uname | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/config.mak.uname b/config.mak.uname index 3236a4918a..d0701f9beb 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -58,7 +58,6 @@ ifeq ($(uname_S),Linux) # -lrt is needed for clock_gettime on glibc <= 2.16 NEEDS_LIBRT = YesPlease HAVE_GETDELIM = YesPlease - SANE_TEXT_GREP=-a FREAD_READS_DIRECTORIES = UnfortunatelyYes BASIC_CFLAGS += -DHAVE_SYSINFO PROCFS_EXECUTABLE_PATH = /proc/self/exe |