diff options
author | Elijah Newren <newren@gmail.com> | 2023-04-16 05:03:05 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2023-04-18 23:01:04 +0200 |
commit | 331b094eec6d4c937af6e59df2a537112e4d8205 (patch) | |
tree | 38b6c65c15b9e719d026cd68917227920f78e268 /connect.c | |
parent | mailmap, quote: move declarations of global vars to correct unit (diff) | |
download | git-331b094eec6d4c937af6e59df2a537112e4d8205.tar.xz git-331b094eec6d4c937af6e59df2a537112e4d8205.zip |
protocol.h: move definition of DEFAULT_GIT_PORT from cache.h
Michael J Gruber noticed that connection via the git:// protocol no
longer worked after a recent header clean-up. This was caused by
funny interaction of few gotchas. First, a necessary definition
#define DEFAULT_GIT_PORT 9418
was made invisible to a place where
const char *port = STR(DEFAULT_GIT_PORT);
was expecting to turn the integer into "9418" with a clever STR()
macro, and ended up stringifying it to
const char *port = "DEFAULT_GIT_PORT";
without giving any chance to compilers to notice such a mistake.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'connect.c')
0 files changed, 0 insertions, 0 deletions