diff options
author | Victoria Dye <vdye@github.com> | 2023-11-14 20:53:57 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2023-11-16 06:03:01 +0100 |
commit | 188782ecb1d326ff724e41a77ea8ccb72f21ad44 (patch) | |
tree | 69e35c608bd0996588f8b4fdc7912265cef8770e /entry.h | |
parent | for-each-ref: clean up documentation of --format (diff) | |
download | git-188782ecb1d326ff724e41a77ea8ccb72f21ad44.tar.xz git-188782ecb1d326ff724e41a77ea8ccb72f21ad44.zip |
ref-filter.c: use peeled tag for '*' format fields
In most builtins ('rev-parse <revision>^{}', 'show-ref --dereference'),
"dereferencing" a tag refers to a recursive peel of the tag object. Unlike
these cases, the dereferencing prefix ('*') in 'for-each-ref' format
specifiers triggers only a single, non-recursive dereference of a given tag
object. For most annotated tags, a single dereference is all that is needed
to access the tag's associated commit or tree; "recursive" and
"non-recursive" dereferencing are functionally equivalent in these cases.
However, nested tags (annotated tags whose target is another annotated tag)
dereferenced once return another tag, where a recursive dereference would
return the commit or tree.
Currently, if a user wants to filter & format refs and include information
about a recursively-dereferenced tag, they can do so with something like
'cat-file --batch-check':
git for-each-ref --format="%(objectname)^{} %(refname)" <pattern> |
git cat-file --batch-check="%(objectname) %(rest)"
But the combination of commands is inefficient. So, to improve the
performance of this use case and align the defererencing behavior of
'for-each-ref' with that of other commands, update the ref formatting code
to use the peeled tag (from 'peel_iterated_oid()') to populate '*' fields
rather than the tag's immediate target object (from 'get_tagged_oid()').
Additionally, add a test to 't6300-for-each-ref' to verify new nested tag
behavior and update 't6302-for-each-ref-filter.sh' to print the correct
value for nested dereferenced fields.
Signed-off-by: Victoria Dye <vdye@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'entry.h')
0 files changed, 0 insertions, 0 deletions